Skip to content

Fix off-by-one column loop (IndexError) and remove redundant shift calculation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Fix off-by-one column loop (IndexError) and remove redundant shift calculation #5

wants to merge 4 commits into from

Conversation

jasseeeem
Copy link

@jasseeeem jasseeeem commented Aug 31, 2025 •
edited
Loading

This PR fixes:

  • An off-by-one error in the per-column roll loop that caused an IndexError at the last iteration by correctly looping through the nubmer of columsn in the image.
    IndexError: index 5789 is out of bounds for axis 1 with size 5789
  • Removes per-channel shift computations recomputed for each color channel unnecessarily.
  • Removes an extra bracket in the function call leading to syntax errors.

@TomStog
Copy link
Owner

TomStog commented Sep 2, 2025

Fixed the issues you pointed. Thank you very much for your insight.

@TomStog TomStog closed this Sep 2, 2025
@jasseeeem jasseeeem deleted the patch-1 branch September 4, 2025 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasseeeem @TomStog