EasyBind.FlattenList(ObservableList<ObservableList<? extends E>>)#10
Closed
Nava2 wants to merge 6 commits intoTomasMikula:masterfrom
Nava2:concat-lists
Closed
EasyBind.FlattenList(ObservableList<ObservableList<? extends E>>)#10Nava2 wants to merge 6 commits intoTomasMikula:masterfrom Nava2:concat-lists
Nava2 wants to merge 6 commits intoTomasMikula:masterfrom
Nava2:concat-lists
Conversation
Creates a new list that combines the values of the given lists. Unlike FXCollections.concat(), updates to the source lists propagate to the combined list.
* Duplicated List values will break the implementation's change events * Added better tests that test different combinations. This commit closes comments in #8.
Author
|
@maul-esel, these are mostly your changes, I just adjusted them with the changes in #8 as it looked "dead." |
* Adds an ObservableList input * Tracks changes to the List, firing changes if the 2D list changes, this eases up the work when bigger changes happen * Change `concat` -> `flattenList`, it's a flatten operation after all
Nava2
changed the title
This was referenced May 5, 2020
|
Since this project sadly doesn't seem to be active any more #16, I've created a fork and continued development there: https://github.com/tobiasdiez/EasyBind. I liked your changes in this PR, and thus included them in the forked repo. Hope this is OK for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a binding to concatenate
ObservableListvalues. This supersedes PR #8. I fixed the bugs that were present in property firing and added some extra tests to verify these components.