Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing #78

Closed
TomerFi opened this issue Aug 1, 2022 · 1 comment · Fixed by #165
Closed

Better testing #78

TomerFi opened this issue Aug 1, 2022 · 1 comment · Fixed by #165
Labels
good first issue Good for newcomers help wanted Contributing help wanted status: confirmed Issue confirmed type: enhancement New feature or request

Comments

@TomerFi
Copy link
Owner

TomerFi commented Aug 1, 2022

What did you have in mind?

We need better testing of the shell script in CI workflows,
today - we basically just test the build and deploy process of the image,
any errors in the underlying shell script might go undetected.

The best "test" we have for the shell script now is the fact we dogfood it for the release workflow,
so technically if the shell script breaks, we won't be able to release.
Nevertheless, more thorough tests for pull requests will be much better.

Are you trying to fix a problem?

Catch bugs and errors early.

Any lead on how this feature may be implemented?

Inspiration might come from version-bumper-action's CI workflows,
a GitHub action that uses this image and performs better tests for pull requests and staging.

@TomerFi TomerFi added type: enhancement New feature or request status: confirmed Issue confirmed help wanted Contributing help wanted good first issue Good for newcomers labels Aug 1, 2022
@welcome
Copy link

welcome bot commented Aug 1, 2022

Thanks for opening your first issue here!

@TomerFi TomerFi linked a pull request Feb 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Contributing help wanted status: confirmed Issue confirmed type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant