Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rebuild project with nodejs #165

Merged
merged 25 commits into from
Feb 8, 2024
Merged

refactor: rebuild project with nodejs #165

merged 25 commits into from
Feb 8, 2024

Conversation

TomerFi
Copy link
Owner

@TomerFi TomerFi commented Feb 6, 2024 •
edited
Loading

This PR introduces BREAKING CHANGES!

GitHub Action PR

This project makes much more sense and is much more maintainable as a Node.js project.

    • The output was changed from a space-delimited text to a JSON object:
      • old 2.1.5 2.1.6-dev
      • new{"current":"2.1.4","bump":"patch","next":"2.1.5","dev":"2.1.6-dev"}

    • Changes in the option flags:
      • --changelog was removed. Creating a changelog file is no longer supported.
      • --outputtype was removed. Output to file is no longer supported.
      • --preset was removed. Selecting a preset is no longer supported.
      • --repopath was changed to --repo (repopath will eventually be removed).
      • --bumpoverride was changed to --bump (bumpoverride will eventually be removed).

      For more info, run the tool with the -h flag (--help).


    • Changes in the container image mount target:
      • from /usr/share/repo
      • to /repo

@TomerFi
build: allow setting image info with Makefile
4c0bec5 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
build: default image builder set to podman
979dc13 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
build: switched to ISC license
ea2e4fe 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
refactor: rewrite project with nodejs
00c75da 
BREAKING CHANGES
- outputype is not longer supported, only printing to stdout
- output is now an object and not a string

Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
test: added unit tests for manual version bumps
bd064ba 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
test: added unit tests for automatic bumps
c26ce8b 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
build: fix up the Dockerfile and other project-related stuff
59c3541 
Signed-off-by: Tomer Figenblat <[email protected]>
@pull-request-size pull-request-size bot added the size: xxl Pull request has more then 1000 lines label Feb 6, 2024
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Feb 6, 2024
@TomerFi TomerFi changed the title refacor: rebuild project with nodejs refactor: rebuild project with nodejs Feb 6, 2024
@TomerFi TomerFi force-pushed the better-project branch 11 times, most recently from 0742a8f to d94ee04 Compare February 6, 2024 15:11
@TomerFi TomerFi marked this pull request as draft February 6, 2024 15:14
@TomerFi
docs: added code documentation
9a9e7a8 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
docs: updated contributing documents
16afee0 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
docs: update README
92ff1d7 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi TomerFi force-pushed the better-project branch 2 times, most recently from 08b70c7 to ec6d9d1 Compare February 7, 2024 01:19
@TomerFi TomerFi force-pushed the better-project branch 3 times, most recently from 57d8c72 to 18cf5e0 Compare February 7, 2024 01:56
@TomerFi
Copy link
Owner Author

TomerFi commented Feb 7, 2024

Hey @MisterTimn and @AlexNDRmac

Both of you contributed it here before, so I am giving you a heads-up regarding this PR, which introduces some breaking changes. I'll start working on the corresponding GitHub action and will merge this soon. The version bump will be 3.0.0.

@TomerFi TomerFi linked an issue Feb 8, 2024 that may be closed by this pull request
Better testing #78
Closed
@TomerFi TomerFi mentioned this pull request Feb 8, 2024
Merged
@TomerFi
docs: fixed tag close in README
4cab8ad 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi
docs: clarified README
62daf02 
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi TomerFi marked this pull request as ready for review February 8, 2024 19:03
@TomerFi TomerFi merged commit be9f459 into master Feb 8, 2024
10 checks passed
@TomerFi TomerFi deleted the better-project branch February 8, 2024 22:57
@auto-me-bot auto-me-bot bot added status: merged Pull request merged and removed status: needs review Pull request needs a review labels Feb 8, 2024
TomerFi added a commit that referenced this pull request Feb 8, 2024
@TomerFi
refactor: rebuild project with nodejs (#165)
aa98d1d 
BREAKING CHANGE:

<h3>This PR introduces BREAKING CHANGES!</h3>

[GitHub Action
PR](TomerFi/version-bumper-action#45)

<strong>This project makes much more sense and is much more maintainable
as a <em>Node.js</em> project.</strong>

<ul>

<ul>

<li>
The output was changed from a space-delimited text to a <em>JSON</em>
object:<br/>
<ul>
<li><strong>old</strong> <code>2.1.5 2.1.6-dev</code><br/></li>

<li><strong>new</strong><code>{"current":"2.1.4","bump":"patch","next":"2.1.5","dev":"2.1.6-dev"}</code></li>
</ul>
</li>
<br/>

<li>
Changes in the option flags:
  <ul>
<li><strong>--changelog</strong> was removed. Creating a changelog file
is no longer supported.</li>
<li><strong>--outputtype</strong> was removed. Output to file is no
longer supported.</li>
<li><strong>--preset</strong> was removed. Selecting a preset is no
longer supported.</li>
<li><strong>--repopath</strong> was changed to <strong>--repo</strong>
(<em>repopath</em> will eventually be removed).</li>
<li><strong>--bumpoverride</strong> was changed to
<strong>--bump</strong> (<em>bumpoverride</em> will eventually be
removed).
  </li>
  </ul>

For more info, run the tool with the <em>-h</em> flag (<em>--help</em>).
</li>
<br/>

<li>Changes in the container image mount target:
<ul>
<li>from <strong>/usr/share/repo</strong></li>
<li>to <strong>/repo</strong></li>
</ul>
</li><br/>

</ul>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
TomerFi added a commit to TomerFi/version-bumper-action that referenced this pull request Feb 9, 2024
@TomerFi
refactor: rebuild action with node.js in preparation of new version-b…
86032e8 
…umper tool version" (#45)

BREAKING CHANGE: 

<h3>This PR introduces BREAKING CHANGES!</h3>

[Tool PR](TomerFi/version-bumper#165)

<ul>

<li>The action was rebuilt using Node.js.</li>

<li>
Changes in the action flags:
  <ul>
  <li><strong>changelog</strong> was removed.</li>
  <li><strong>preset</strong> was removed.</li>
<li><strong>folder</strong> was changed to <strong>path</strong>. It's
worth mentioning the folder/path requires a
full path and not a folder relative to the workspace. (<em>folder</em>
will eventually be removed).</li>
<li><strong>bumpoverride</strong> was changed to <strong>bump</strong>
(<em>bumpoverride</em> will eventually be removed).
  </li>
  </ul>
</li>
<br/>

</ul>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TomerFi TomerFi

Labels
size: xxl Pull request has more then 1000 lines status: merged Pull request merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better testing
1 participant
@TomerFi