-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rebuild action with node.js in preparation of new version-bumper tool version" #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
Hey @MisterTimn, @mrdoodles, and @g4m3r0 All of you contributed it here before, so I am giving you a heads-up regarding this PR, which introduces some breaking changes. It will be merged soon. The version bump will be |
TomerFi
force-pushed
the
refactor-action
branch
11 times, most recently
from
February 8, 2024 14:31
a2f2e47
to
0211b29
Compare
Signed-off-by: Tomer Figenblat <[email protected]>
TomerFi
force-pushed
the
refactor-action
branch
4 times, most recently
from
February 8, 2024 21:48
2846e83
to
f4ada0b
Compare
Signed-off-by: Tomer Figenblat <[email protected]>
TomerFi
force-pushed
the
refactor-action
branch
from
February 8, 2024 21:50
f4ada0b
to
ba61ca5
Compare
TomerFi
added a commit
to TomerFi/version-bumper
that referenced
this pull request
Feb 8, 2024
<h3>This PR introduces BREAKING CHANGES!</h3> [GitHub Action PR](TomerFi/version-bumper-action#45) <strong>This project makes much more sense and is much more maintainable as a <em>Node.js</em> project.</strong> <ul> <ul> <li> The output was changed from a space-delimited text to a <em>JSON</em> object:<br/> <ul> <li><strong>old</strong> <code>2.1.5 2.1.6-dev</code><br/></li> <li><strong>new</strong><code>{"current":"2.1.4","bump":"patch","next":"2.1.5","dev":"2.1.6-dev"}</code></li> </ul> </li> <br/> <li> Changes in the option flags: <ul> <li><strong>--changelog</strong> was removed. Creating a changelog file is no longer supported.</li> <li><strong>--outputtype</strong> was removed. Output to file is no longer supported.</li> <li><strong>--preset</strong> was removed. Selecting a preset is no longer supported.</li> <li><strong>--repopath</strong> was changed to <strong>--repo</strong> (<em>repopath</em> will eventually be removed).</li> <li><strong>--bumpoverride</strong> was changed to <strong>--bump</strong> (<em>bumpoverride</em> will eventually be removed). </li> </ul> For more info, run the tool with the <em>-h</em> flag (<em>--help</em>). </li> <br/> <li>Changes in the container image mount target: <ul> <li>from <strong>/usr/share/repo</strong></li> <li>to <strong>/repo</strong></li> </ul> </li><br/> </ul> --------- Signed-off-by: Tomer Figenblat <[email protected]>
TomerFi
added a commit
to TomerFi/version-bumper
that referenced
this pull request
Feb 8, 2024
BREAKING CHANGE: <h3>This PR introduces BREAKING CHANGES!</h3> [GitHub Action PR](TomerFi/version-bumper-action#45) <strong>This project makes much more sense and is much more maintainable as a <em>Node.js</em> project.</strong> <ul> <ul> <li> The output was changed from a space-delimited text to a <em>JSON</em> object:<br/> <ul> <li><strong>old</strong> <code>2.1.5 2.1.6-dev</code><br/></li> <li><strong>new</strong><code>{"current":"2.1.4","bump":"patch","next":"2.1.5","dev":"2.1.6-dev"}</code></li> </ul> </li> <br/> <li> Changes in the option flags: <ul> <li><strong>--changelog</strong> was removed. Creating a changelog file is no longer supported.</li> <li><strong>--outputtype</strong> was removed. Output to file is no longer supported.</li> <li><strong>--preset</strong> was removed. Selecting a preset is no longer supported.</li> <li><strong>--repopath</strong> was changed to <strong>--repo</strong> (<em>repopath</em> will eventually be removed).</li> <li><strong>--bumpoverride</strong> was changed to <strong>--bump</strong> (<em>bumpoverride</em> will eventually be removed). </li> </ul> For more info, run the tool with the <em>-h</em> flag (<em>--help</em>). </li> <br/> <li>Changes in the container image mount target: <ul> <li>from <strong>/usr/share/repo</strong></li> <li>to <strong>/repo</strong></li> </ul> </li><br/> </ul> --------- Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
auto-me-bot
bot
added
status: merged
Pull request merged
and removed
status: needs review
Pull request needs a review
labels
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces BREAKING CHANGES!
Tool PR