Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rebuild action with node.js in preparation of new version-bumper tool version" #45

Merged
merged 7 commits into from
Feb 9, 2024

Conversation

TomerFi
Copy link
Owner

@TomerFi TomerFi commented Feb 8, 2024

This PR introduces BREAKING CHANGES!

Tool PR

  • The action was rebuilt using Node.js.
  • Changes in the action flags:
    • changelog was removed.
    • preset was removed.
    • folder was changed to path. It's worth mentioning the folder/path requires a full path and not a folder relative to the workspace. (folder will eventually be removed).
    • bumpoverride was changed to bump (bumpoverride will eventually be removed).

Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
Signed-off-by: Tomer Figenblat <[email protected]>
@pull-request-size pull-request-size bot added the size: xxl Pull request has more then 1000 lines label Feb 8, 2024
@auto-me-bot auto-me-bot bot added the status: needs review Pull request needs a review label Feb 8, 2024
@TomerFi TomerFi marked this pull request as draft February 8, 2024 05:57
@TomerFi
Copy link
Owner Author

TomerFi commented Feb 8, 2024

Hey @MisterTimn, @mrdoodles, and @g4m3r0

All of you contributed it here before, so I am giving you a heads-up regarding this PR, which introduces some breaking changes. It will be merged soon. The version bump will be 2.0.0.

@TomerFi TomerFi force-pushed the refactor-action branch 11 times, most recently from a2f2e47 to 0211b29 Compare February 8, 2024 14:31
Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi TomerFi force-pushed the refactor-action branch 4 times, most recently from 2846e83 to f4ada0b Compare February 8, 2024 21:48
Signed-off-by: Tomer Figenblat <[email protected]>
TomerFi added a commit to TomerFi/version-bumper that referenced this pull request Feb 8, 2024
<h3>This PR introduces BREAKING CHANGES!</h3>

[GitHub Action
PR](TomerFi/version-bumper-action#45)

<strong>This project makes much more sense and is much more maintainable
as a <em>Node.js</em> project.</strong>

<ul>

<ul>

<li>
The output was changed from a space-delimited text to a <em>JSON</em>
object:<br/>
<ul>
<li><strong>old</strong> <code>2.1.5 2.1.6-dev</code><br/></li>

<li><strong>new</strong><code>{"current":"2.1.4","bump":"patch","next":"2.1.5","dev":"2.1.6-dev"}</code></li>
</ul>
</li>
<br/>

<li>
Changes in the option flags:
  <ul>
<li><strong>--changelog</strong> was removed. Creating a changelog file
is no longer supported.</li>
<li><strong>--outputtype</strong> was removed. Output to file is no
longer supported.</li>
<li><strong>--preset</strong> was removed. Selecting a preset is no
longer supported.</li>
<li><strong>--repopath</strong> was changed to <strong>--repo</strong>
(<em>repopath</em> will eventually be removed).</li>
<li><strong>--bumpoverride</strong> was changed to
<strong>--bump</strong> (<em>bumpoverride</em> will eventually be
removed).
  </li>
  </ul>

For more info, run the tool with the <em>-h</em> flag (<em>--help</em>).
</li>
<br/>

<li>Changes in the container image mount target:
<ul>
<li>from <strong>/usr/share/repo</strong></li>
<li>to <strong>/repo</strong></li>
</ul>
</li><br/>

</ul>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
TomerFi added a commit to TomerFi/version-bumper that referenced this pull request Feb 8, 2024
BREAKING CHANGE:

<h3>This PR introduces BREAKING CHANGES!</h3>

[GitHub Action
PR](TomerFi/version-bumper-action#45)

<strong>This project makes much more sense and is much more maintainable
as a <em>Node.js</em> project.</strong>

<ul>

<ul>

<li>
The output was changed from a space-delimited text to a <em>JSON</em>
object:<br/>
<ul>
<li><strong>old</strong> <code>2.1.5 2.1.6-dev</code><br/></li>

<li><strong>new</strong><code>{"current":"2.1.4","bump":"patch","next":"2.1.5","dev":"2.1.6-dev"}</code></li>
</ul>
</li>
<br/>

<li>
Changes in the option flags:
  <ul>
<li><strong>--changelog</strong> was removed. Creating a changelog file
is no longer supported.</li>
<li><strong>--outputtype</strong> was removed. Output to file is no
longer supported.</li>
<li><strong>--preset</strong> was removed. Selecting a preset is no
longer supported.</li>
<li><strong>--repopath</strong> was changed to <strong>--repo</strong>
(<em>repopath</em> will eventually be removed).</li>
<li><strong>--bumpoverride</strong> was changed to
<strong>--bump</strong> (<em>bumpoverride</em> will eventually be
removed).
  </li>
  </ul>

For more info, run the tool with the <em>-h</em> flag (<em>--help</em>).
</li>
<br/>

<li>Changes in the container image mount target:
<ul>
<li>from <strong>/usr/share/repo</strong></li>
<li>to <strong>/repo</strong></li>
</ul>
</li><br/>

</ul>

---------

Signed-off-by: Tomer Figenblat <[email protected]>
@TomerFi TomerFi marked this pull request as ready for review February 9, 2024 02:55
@TomerFi TomerFi merged commit 86032e8 into master Feb 9, 2024
7 checks passed
@TomerFi TomerFi deleted the refactor-action branch February 9, 2024 04:15
@auto-me-bot auto-me-bot bot added status: merged Pull request merged and removed status: needs review Pull request needs a review labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xxl Pull request has more then 1000 lines status: merged Pull request merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant