-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing unit tests #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change the open and close form situation in this same PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry what do you mean by this? |
I mean that when we run the tests the forms are opening and closing quickly, and we discussed (in private) to change this so the forms are not opened in the tests at all. I was thinking this PR is a good place to fix this unless we want to open a new issue for it. |
We should open a new issue for it, this PR is just addressing failing unit tests |
I opened a new issue for this #110 (comment) |
Thanks! |
Closes #78
TestMainWindowWithSessionManagementCreateLoadSessionDialog
test into a separate file:test\test_MainWindowWithSessionManagementDialogs.py
because this needed to test elements ofLoadSessionDialog
whose import had been mocked elsewhere in thetest\test_MainWindowWithSessionManagement.py
file for other tests.dialog.open()
instead ofdialog._exec()