Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing unit tests #106

Merged
merged 6 commits into from
Nov 24, 2023
Merged

Fix failing unit tests #106

merged 6 commits into from
Nov 24, 2023

Conversation

lauramurgatroyd
Copy link
Member

@lauramurgatroyd lauramurgatroyd commented Nov 21, 2023

Closes #78

  • I had to move the TestMainWindowWithSessionManagementCreateLoadSessionDialog test into a separate file: test\test_MainWindowWithSessionManagementDialogs.py because this needed to test elements of LoadSessionDialog whose import had been mocked elsewhere in the test\test_MainWindowWithSessionManagement.py file for other tests.
  • In one test there was a dialog which was opened and blocked the other tests from running until we physically closed the dialog. I prevented this by using dialog.open() instead of dialog._exec()
  • Fixed a failing unit test due to incorrect whitespace in a string.

@DanicaSTFC DanicaSTFC self-assigned this Nov 21, 2023
@DanicaSTFC DanicaSTFC added this to the v1.0.0 milestone Nov 22, 2023
Copy link
Member

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@DanicaSTFC DanicaSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the open and close form situation in this same PR?

Copy link
Collaborator

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lauramurgatroyd
Copy link
Member Author

Should we change the open and close form situation in this same PR?

Sorry what do you mean by this?

@DanicaSTFC
Copy link
Collaborator

Should we change the open and close form situation in this same PR?

Sorry what do you mean by this?

I mean that when we run the tests the forms are opening and closing quickly, and we discussed (in private) to change this so the forms are not opened in the tests at all. I was thinking this PR is a good place to fix this unless we want to open a new issue for it.

@lauramurgatroyd
Copy link
Member Author

We should open a new issue for it, this PR is just addressing failing unit tests

@DanicaSTFC
Copy link
Collaborator

We should open a new issue for it, this PR is just addressing failing unit tests

I opened a new issue for this #110 (comment)

@lauramurgatroyd
Copy link
Member Author

Thanks!

@casperdcl casperdcl merged commit d476c13 into main Nov 24, 2023
@casperdcl casperdcl deleted the fix_unit_tests branch November 24, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix failing test
4 participants