feat: propagate additional products #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case customers want to attribute purchases to banners they need to specify a product and a resolved bid as inherit. In such a case we would grab the resolved id id that was stored in session storage in the previous click. There are some caveats with this approach: 1) If there's a mistake and an inherit resolved bid is used in a page which is not the target of a banner, then the events will fail. 2) It could happen that the user manually changes the url to a banner's destination page and in that case we would report the events to the wrong banner. 3) This won't always work if session storage is not available (support is 97.4% https://caniuse.com/mdn-api_window_sessionstorage). We have a fallback using an in memory cache, but that would only work if the page it's not reloaded (Vue, React, etc)
jbergstroem
reviewed
Nov 9, 2023
jbergstroem
approved these changes
Nov 10, 2023
PabloReszczynski
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case customers want to attribute purchases to banners they need to specify a product and a resolved bid as inherit. In such a case we would grab the resolved id id that was stored in session storage in the previous click.
There are some caveats with this approach: