-
Notifications
You must be signed in to change notification settings - Fork 201
Add key_prefix and db configuration options #1728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add key_prefix and db configuration options #1728
Conversation
|
Thank you for the contribution. It's almost ready for review. Simple fix here: > index 38f06c8..5cd5b44 100644
> --- a/nativelink-config/examples/redis.json5
> +++ b/nativelink-config/examples/redis.json5
> @@ -75,4 +75,4 @@
> }
> }
> ]
> -}
> \ No newline at end of file
> +}you only need an empty line at the end of Granted, I haven't tested the functionality, but I will. @barrbrain and @aaronmondal and @kubevalet will also be keen to test it. |
4435fdb to
924f127
Compare
|
@MarcusSorealheis Thank you for the feedback. I've fixed that part. |
|
I've merged with main to catch up and observe if anything new breaks. |
|
@dinceraslancom You need to sign the CLA? |
|
Could you also add a test? |
|
@MarcusSorealheis I already confirmed the CLA, but there was an issue with email matching, solved. I will write test case. |
1564485 to
40ae792
Compare
Description
This update fixes issues in RedisStore and RedisScheduler from #1585.
Use key_prefix to add a custom prefix to all keys.
Choose a db number instead of always using 0.
Fixes # (1585)
Type of change
How Has This Been Tested?
Configured nativelink-config/examples/redis.json5 with both key_prefix: "my_test_prefix:" and db: 1.
Started Redis locally using Docker.
Started Nativelink using bazel run //:nativelink -- $(pwd)/nativelink-config/examples/redis.json5
Used redis-cli MONITOR to watch Redis commands.
See Redis commands always using keys with my_test_prefix:.
Checklist
bazel test //...passes locallyThis PR contains two distinct logical commits (one for key_prefix, one for db selection) for clarity in history
This change is