[Breaking] Change bytestream to array-based config #1848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amankrx
force-pushed
the
bytestream-config
branch
from
ec97b4d to
4804332
Compare
amankrx
force-pushed
the
bytestream-config
branch
from
4804332 to
9b15eb4
Compare
amankrx
force-pushed
the
bytestream-config
branch
from
9b15eb4 to
9254721
Compare
|
Please just resolve the conflicts in the original PR. |
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
MarcusSorealheis
temporarily deployed
to
production
GitHub Actions
Inactive
palfrey
requested changes
Jul 4, 2025
| _timeout_streaam_drop_guard: spawn!("bytestream_idle_stream_timeout", async move { | ||
| (*sleep_fn)().await; | ||
| _timeout_stream_drop_guard: spawn!("bytestream_idle_stream_timeout", async move { | ||
| sleep(timeout).await; |
There was a problem hiding this comment.
Why the change? Doesn't feel related to the other bytestream work?
|
|
||
| let store_config = self | ||
| .get_store_config(instance_name) | ||
| .err_tip(|| format!("'instance_name' not configured for '{instance_name}'"))?; |
There was a problem hiding this comment.
get_store_config already does this error
|
|
||
| let store_config = self | ||
| .get_store_config(&instance_name) | ||
| .err_tip(|| format!("'instance_name' not configured for '{instance_name}'"))?; |
There was a problem hiding this comment.
get_store_config already does this error
| "content_path": "/tmp/nativelink/data-worker-test/content_path-cas", | ||
| "temp_path": "/tmp/nativelink/data-worker-test/tmp_path-cas", | ||
| "eviction_policy": { | ||
| // 10gb. |
There was a problem hiding this comment.
Comment can go away now it's written out
| "container-image": { | ||
| "values": [""] | ||
| }, | ||
| // Example of how to set which docker images are available and set |
8 tasks
amankrx
force-pushed
the
bytestream-config
branch
from
1fb3bcc to
40bd484
Compare
In contrast to TraceMachina#1712, there's no backwards-compatibility layer. Closes TraceMachina#1649 Fix the merge conflicts for the Bytestream config JSON file
amankrx
force-pushed
the
bytestream-config
branch
from
40bd484 to
e38ff56
Compare
|
Obsoleted by #1951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the previously opened PR to change the bytestream to array-based config.
In contrast to #1712, there's no backwards-compatibility layer.
Closes #1649
Description
Please include a summary of the changes and the related issue. Please also
include relevant motivation and context.
Fixes # (issue)
Type of change
Please delete options that aren't relevant.
not work as expected)
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docsThis change is
Co-authored by @jaroeichler