Skip to content

Initial implementation of remote persistent workers #1922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Initial implementation of remote persistent workers #1922

wants to merge 8 commits into from

Conversation

@MarcusSorealheis
Copy link
Collaborator

@MarcusSorealheis MarcusSorealheis commented Sep 3, 2025 •
edited
Loading

Description

Remote persistent workers are coming to Nativelink! Not there yet.

Fixes # (issue)

Type of change

Please delete options that aren't relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please also list any relevant details for your test configuration

Checklist

  • Updated documentation if needed
  • Tests added/amended
  • bazel test //... passes locally
  • PR is contained in a single commit, using git amend see some docs

This change is Reviewable

@MarcusSorealheis MarcusSorealheis marked this pull request as draft September 3, 2025 23:41
@MarcusSorealheis MarcusSorealheis force-pushed the remote-persistent-workers branch from 42c8b8e to c69655d Compare September 4, 2025 01:12
@MarcusSorealheis
Fix pre-commit issues
c35b3c2 
- Apply generate-bazel-rc auto-fixes to .bazelrc
- Remove unused dependencies (hyper-util, tracing-test)
- Fix Vale documentation style issues in README
  - Replace e.g., with 'for example'
  - Use backticks for filenames and compiler names
  - Fix namespace terminology
@MarcusSorealheis MarcusSorealheis marked this pull request as ready for review November 4, 2025 19:40
@MarcusSorealheis
Fix critical bug: restore tracing-test dependency
2630ee1 
The tracing-test dependency is required by the #[nativelink_test] macro.
Cargo-machete incorrectly flagged it as unused because it's used by the
macro expansion, not directly in code.

Added cargo-machete ignore metadata to prevent future false positives.
palfrey
palfrey reviewed Nov 5, 2025
View reviewed changes
Cargo.toml
Copy link
Member

@palfrey palfrey Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and various other config files appear to have been reset to ~0.7.1 era (given the versions) and they remove a bunch of fixes I've done in that time. Possibly merge issues?

Copy link
Collaborator Author

@MarcusSorealheis MarcusSorealheis Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. Let me try to get this fixed.

palfrey
palfrey reviewed Nov 5, 2025
View reviewed changes
nativelink-store/MODULE.bazel
Copy link
Member

@palfrey palfrey Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palfrey palfrey palfrey requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcusSorealheis @palfrey @amankrx