Skip to content

Match undeclared platform properties dynamically instead of rejecting them - #2705

Merged
amankrx merged 2 commits into
TraceMachina:mainfrom
amankrx:feat/dynamic-platform-properties
Aug 21, 2026
Merged

Match undeclared platform properties dynamically instead of rejecting them#2705
amankrx merged 2 commits into
TraceMachina:mainfrom
amankrx:feat/dynamic-platform-properties

Conversation

@amankrx

@amankrx amankrx commented Aug 20, 2026

Copy link
Copy Markdown
Member

What and why

An action or worker carrying a platform property key the scheduler's supported_platform_properties does not declare was rejected outright: workers refused at registration, actions logged Unknown platform property and sat queued forever. Undeclared keys now become Unknown values that wildcard-match: the action still routes, matching on the declared keys, and an undeclared key on both sides matches by exact string. Declared property types keep their existing semantics untouched.

How was this verified?

New tests in platform_property_manager_test.rs, worker_capability_index_test.rs and platform_properties_tests.rs: an undeclared key no longer errors (this failed before the change), exact-string matching between undeclared keys on action and worker, missing-key wildcard behaviour through the capability index, and the default property names (cpu_count, memory_kb, gpu_count, container-image) parsing under every declared type.

Risk

Behaviour change: configs relying on the scheduler rejecting a typo'd property key now match instead, so a misspelled exact constraint routes more broadly rather than erroring. Declared keys behave exactly as before; the change only affects keys absent from supported_platform_properties.


This change is Reviewable

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nativelink Ready Ready Preview Aug 20, 2026 11:51pm
nativelink-aidm Ready Ready Preview Aug 20, 2026 11:51pm

Request Review

@MarcusSorealheis MarcusSorealheis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MarcusSorealheis

Copy link
Copy Markdown
Member

We have needed this for years

@amankrx
amankrx merged commit 2978a1d into TraceMachina:main Aug 21, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants