Match undeclared platform properties dynamically instead of rejecting them - #2705
Merged
amankrx merged 2 commits intoAug 21, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
We have needed this for years |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
An action or worker carrying a platform property key the scheduler's
supported_platform_propertiesdoes not declare was rejected outright: workers refused at registration, actions loggedUnknown platform propertyand sat queued forever. Undeclared keys now becomeUnknownvalues that wildcard-match: the action still routes, matching on the declared keys, and an undeclared key on both sides matches by exact string. Declared property types keep their existing semantics untouched.How was this verified?
New tests in
platform_property_manager_test.rs,worker_capability_index_test.rsandplatform_properties_tests.rs: an undeclared key no longer errors (this failed before the change), exact-string matching between undeclared keys on action and worker, missing-key wildcard behaviour through the capability index, and the default property names (cpu_count,memory_kb,gpu_count,container-image) parsing under every declared type.Risk
Behaviour change: configs relying on the scheduler rejecting a typo'd property key now match instead, so a misspelled
exactconstraint routes more broadly rather than erroring. Declared keys behave exactly as before; the change only affects keys absent fromsupported_platform_properties.This change is