Skip to content

Commit

Permalink
revert: "ci(build): Skip next js linting in docker build"
Browse files Browse the repository at this point in the history
This reverts commit c0cf31a.
  • Loading branch information
topher-lo committed Dec 3, 2024
1 parent 9ec133d commit e30ee03
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 41 deletions.
35 changes: 0 additions & 35 deletions .github/workflows/build-push-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,41 +62,6 @@ jobs:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'

- name: Install pnpm
uses: pnpm/action-setup@v2
with:
version: 8

- name: Get pnpm store directory
shell: bash
run: |
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
- name: Setup pnpm cache
uses: actions/cache@v3
with:
path: ${{ env.STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
- name: Install dependencies
working-directory: frontend
run: pnpm install --frozen-lockfile

- name: Run type checking
working-directory: frontend
run: pnpm type-check

- name: Run linting
working-directory: frontend
run: pnpm lint

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

Expand Down
6 changes: 0 additions & 6 deletions frontend/Dockerfile.prod
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,6 @@ COPY --from=deps /app/node_modules ./node_modules

# Copy all source files and build the application
COPY . .

# Skip type checking and linting during Docker build since we did it in CI
ENV NEXT_TELEMETRY_DISABLED=1
ENV SKIP_TYPE_CHECK=true
ENV SKIP_LINT=true

RUN corepack enable pnpm && pnpm build

# Use the Node.js Alpine image as the base image for the runner stage
Expand Down

0 comments on commit e30ee03

Please sign in to comment.