Skip to content

Commit

Permalink
build: Make TRACECAT__SETTING_OVERRIDE_SAML_ENABLED explicit
Browse files Browse the repository at this point in the history
  • Loading branch information
topher-lo committed Jan 16, 2025
1 parent 7ba6ba1 commit ea63805
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ USER_AUTH_SECRET=your-auth-secret

# SAML SSO settings
SAML_IDP_METADATA_URL=
TRACECAT__SETTING_OVERRIDE_SAML_ENABLED= # Enables SAML on startup

This comment has been minimized.

Copy link
@szymon-romanko

szymon-romanko Jan 20, 2025

Contributor

shouldn't that be false or ""?
because it causes error while installing
its parsed as TRACECAT__SETTING_OVERRIDE_SAML_ENABLED=" # Enables SAML on startup"
let me know, i can give you more info and logs from my deployment


# --- Temporal ---
TEMPORAL__CLUSTER_URL=temporal:7233
Expand Down
1 change: 1 addition & 0 deletions docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ services:
TRACECAT__AUTH_TYPES: ${TRACECAT__AUTH_TYPES}
TRACECAT__AUTH_ALLOWED_DOMAINS: ${TRACECAT__AUTH_ALLOWED_DOMAINS}
TRACECAT__AUTH_MIN_PASSWORD_LENGTH: ${TRACECAT__AUTH_MIN_PASSWORD_LENGTH}
TRACECAT__SETTING_OVERRIDE_SAML_ENABLED: ${TRACECAT__SETTING_OVERRIDE_SAML_ENABLED}
TRACECAT__EXECUTOR_URL: ${INTERNAL_EXECUTOR_URL}
OAUTH_CLIENT_ID: ${OAUTH_CLIENT_ID}
OAUTH_CLIENT_SECRET: ${OAUTH_CLIENT_SECRET}
Expand Down
1 change: 1 addition & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ services:
TRACECAT__AUTH_TYPES: ${TRACECAT__AUTH_TYPES}
TRACECAT__AUTH_ALLOWED_DOMAINS: ${TRACECAT__AUTH_ALLOWED_DOMAINS}
TRACECAT__AUTH_MIN_PASSWORD_LENGTH: ${TRACECAT__AUTH_MIN_PASSWORD_LENGTH}
TRACECAT__SETTING_OVERRIDE_SAML_ENABLED: ${TRACECAT__SETTING_OVERRIDE_SAML_ENABLED}
TRACECAT__EXECUTOR_URL: ${INTERNAL_EXECUTOR_URL}
OAUTH_CLIENT_ID: ${OAUTH_CLIENT_ID}
OAUTH_CLIENT_SECRET: ${OAUTH_CLIENT_SECRET}
Expand Down

0 comments on commit ea63805

Please sign in to comment.