fix: remove redundant NewGenericSyntax from mypy.ini - #802
Merged
Merged
Conversation
… by default for py 3.12+) Fixes warning emitted on every `make typecheck` run since python_version was raised to 3.13 in PR Tracer-Cloud#727.
Contributor
Greptile SummaryRemoves the Confidence Score: 5/5Safe to merge — removes a single redundant config line with no functional impact. The change is a one-line deletion of a flag that mypy itself reports as redundant for the configured Python version. No logic, runtime code, or type-checking behaviour is affected. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["make typecheck"] --> B["mypy invoked\n(python_version = 3.13)"]
B --> C{"mypy >= 1.12?"}
C -- "yes" --> D["NewGenericSyntax\nenabled by default"]
D --> E_old["⚠️ Warning: already enabled\n(before this PR)"]
D --> E_new["✅ No warning\n(after this PR)"]
C -- "no" --> F["feature flag needed\n(not applicable here)"]
Reviews (1): Last reviewed commit: "fix: remove redundant NewGenericSyntax f..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
Warning: NewGenericSyntax is already enabled by defaultwarning emitted on everymake typecheckrun.Root cause:
python_version = 3.13was raised in PR #727 but theenable_incomplete_feature = NewGenericSyntaxline was left behind. Since mypy 1.12+, this feature is enabled by default for Python 3.12+, making the flag redundant.Fix: remove the redundant line from
mypy.ini. Type-checking still passes on all 385 source files.Closes #797