Skip to content

fix: remove redundant NewGenericSyntax from mypy.ini - #802

Merged
VaibhavUpreti merged 1 commit into
Tracer-Cloud:mainfrom
fuleinist:main
Apr 24, 2026
Merged

VaibhavUpreti merged 1 commit into
Tracer-Cloud:mainfrom
fuleinist:main

Conversation

@fuleinist

Copy link
Copy Markdown
Contributor

Fixes the Warning: NewGenericSyntax is already enabled by default warning emitted on every make typecheck run.

Root cause: python_version = 3.13 was raised in PR #727 but the enable_incomplete_feature = NewGenericSyntax line was left behind. Since mypy 1.12+, this feature is enabled by default for Python 3.12+, making the flag redundant.

Fix: remove the redundant line from mypy.ini. Type-checking still passes on all 385 source files.

Closes #797

… by default for py 3.12+)

Fixes warning emitted on every `make typecheck` run since python_version was raised to 3.13 in PR Tracer-Cloud#727.
@greptile-apps

greptile-apps Bot commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the enable_incomplete_feature = NewGenericSyntax line from mypy.ini that became redundant after python_version was bumped to 3.13 in PR #727. Since mypy 1.12+, NewGenericSyntax is on by default for Python 3.12+, so the retained flag caused a spurious warning on every make typecheck run.

Confidence Score: 5/5

Safe to merge — removes a single redundant config line with no functional impact.

The change is a one-line deletion of a flag that mypy itself reports as redundant for the configured Python version. No logic, runtime code, or type-checking behaviour is affected.

No files require special attention.

Important Files Changed

Filename Overview
mypy.ini Removes the now-redundant enable_incomplete_feature = NewGenericSyntax line; with python_version = 3.13 and mypy 1.12+, this feature is enabled by default so the flag only produced a warning.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A["make typecheck"] --> B["mypy invoked\n(python_version = 3.13)"]
    B --> C{"mypy >= 1.12?"}
    C -- "yes" --> D["NewGenericSyntax\nenabled by default"]
    D --> E_old["⚠️ Warning: already enabled\n(before this PR)"]
    D --> E_new["✅ No warning\n(after this PR)"]
    C -- "no" --> F["feature flag needed\n(not applicable here)"]
Loading

Reviews (1): Last reviewed commit: "fix: remove redundant NewGenericSyntax f..." | Re-trigger Greptile

@VaibhavUpreti
VaibhavUpreti merged commit 1415981 into Tracer-Cloud:main Apr 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] mypy emits "NewGenericSyntax is already enabled by default" warning on every typecheck run

2 participants