fix(agera,kida,nanoviews,query): run user reducers and event handlers untracked - #193
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 84.54% 84.59% +0.05%
==========================================
Files 139 139
Lines 3112 3116 +4
Branches 580 578 -2
==========================================
+ Hits 2631 2636 +5
Misses 343 343
+ Partials 138 137 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
… untracked - `nextValue` calls the reducer form of a signal write with tracking off, so `$signal(value => value + $other())` no longer subscribes whatever effect performs the write; it also takes an extra argument to pass to the reducer - route the query cache setter and kida child setter through `nextValue` instead of their own `isFunction` branches - run delegated event handlers untracked: an event dispatched synchronously from an effect - `element.focus()` under `autoFocus$` - no longer subscribes that effect to what the handler reads, which could steal focus back on every unrelated change
dangreen
force-pushed
the
fix/untracked-user-callbacks
branch
from
August 10, 2026 21:33
899f30b to
39c5eec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tracking barriers around code the library user writes, found by a repo-wide audit of
untrackedcoverage.nextValuecalls the reducer form of a signal write with tracking off, so$signal(value => value + $other())no longer subscribes whatever effect performs the write; it also takes an extra argument to pass to the reducernextValueinstead of their ownisFunctionbrancheselement.focus()underautoFocus$- no longer subscribes that effect to what the handler reads, which could steal focus back on every unrelated changeEvery fix has a regression test that is red without it:
signal.spec.ts(the core reducer),array.spec.ts(updateArray),cache.spec.ts($data),effects.spec.ts(delegated events).Measured along the way: rest parameters for the reducer argument are ~2.3x slower than a single optional one, so the signature takes one argument;
pushActiveSub()without the explicitundefinedis perf-neutral but costs bytes, so the call sites keep it.Sizes: agera 2730 / 1345 / 1513 / 1927, kida 4188 / 1349 / 2273, nanoviews 6845 / 4044, store 5609 / 1349 / 2274 - the core barrier reaches every bundle because it sits in the single funnel of functional writes. Suites: agera 126 + 1 expected fail, kida 62, store 57, nanoviews 73, query 163, router 129.
🤖 Generated with Claude Code