feat: enhance build-docs utility with pnpm and Nix support#8574
feat: enhance build-docs utility with pnpm and Nix support#8574kalbasit wants to merge 1 commit intoTriliumNext:mainfrom
Conversation
|
Related Documentation No published documentation to review for changes on this repository. |
Summary of ChangesHello @kalbasit, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly enhances the build-docs utility by making it a standalone, configurable CLI tool with pnpm and Nix support. The changes are well-structured and align with the goal of improving portability for CI/CD integration.
I've added a few suggestions to improve code clarity and maintainability. Specifically, I've pointed out an opportunity to simplify the config loading logic, a duplicated log message, and a duplicated helper function that could be refactored into a shared utility.
Overall, this is a great contribution that makes the documentation build process more robust and easier to use.
This enhances the `build-docs` utility to allow running it via pnpm and packaging it as a Nix application. Changes include: - Added `build` and `cli` scripts to `apps/build-docs/package.json`. - Implemented a standalone CLI wrapper for documentation generation. - Added a `trilium-build-docs` package to the Nix flake for use in other projects. - Integrated `apps/build-docs` into the Nix workspace and build pipeline. These changes make the documentation build process more portable and easier to integrate into CI/CD pipelines outside of the main repository.
5a8e12e to
07f273f
Compare
This enhances the
build-docsutility to allow running it via pnpm and packaging it as a Nix application. Changes include:buildandcliscripts toapps/build-docs/package.json.trilium-build-docspackage to the Nix flake for use in other projects.apps/build-docsinto the Nix workspace and build pipeline.These changes make the documentation build process more portable and easier to integrate into CI/CD pipelines outside of the main repository. I plan to use this to complement edit-docs in ncps to automatically build the website and push it from a CI job.