always show Note Paths in Status Bar

[contributor]

This is useful if a note is opened from a saved search (no other way to find out note's path).

In old layout it works ok (you can see the paths in search result), but in new layout this is one the things that was not done right.

Note: I left enabled flag in use. In the future visibility of status bar items may be controlled through options.

[gemini-code-assist]

Summary of Changes

Hello @contributor, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by ensuring that note paths are consistently visible in the status bar. Previously, note paths might not have been displayed under certain conditions, such as when a note was opened from a search tree in the new layout. By unconditionally enabling the display of note paths, users will always have immediate access to this contextual information, improving navigation and understanding of note locations.

Highlights

• Note Path Visibility: The status bar will now always display note paths, regardless of the number of paths available. This change addresses a usability issue where paths were not always visible, particularly for notes opened from search results in the new layout.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• apps/client/src/widgets/layout/StatusBar.tsx
  • Modified the NotePaths component to always set the enabled flag to true, ensuring that note paths are perpetually visible in the status bar.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the status bar to always show the 'Note Paths' component, which is a sensible change for usability, especially for notes opened from search results. My feedback includes a suggestion to add a code comment to clarify the intent behind hardcoding the enabled flag, which will improve long-term maintainability.

[gemini-code-assist]

This change makes sense to always show the note paths. As you mentioned in the PR description, you've kept the enabled flag for future configurability. It would be beneficial to add a comment in the code to reflect this intent. This will help other developers understand why this is hardcoded and that it's intended to be changed later.

Suggested change

	const enabled = true;
	// Always show note paths. This may become configurable in the future.
	const enabled = true;

[eliandoran]

@contributor , is search notes the only use case where the paths need to be shown?
If so, can't we detect if the note has a search note path instead? (I saw something like that in fnote where you do FNote#getParentNotes and check if at least one of them has type === "search").

There is a reason why we are hiding the note paths in the status bar: they occupy unnecessary space if there is only one path. I would argue the number of notes with one path is generally larger than the ones with multiple paths.

[contributor]

@contributor , is search notes the only use case where the paths need to be shown? If so, can't we detect if the note has a search note path instead? (I saw something like that in fnote where you do FNote#getParentNotes and check if at least one of them has type === "search").

We could try, but is it worth to make a special case?

Even for a regular note, it is good to have path accessible. Bread crumb often has abbreviated paths even on a wide monitor:

There is a reason why we are hiding the note paths in the status bar: they occupy unnecessary space if there is only one path. I would argue the number of notes with one path is generally larger than the ones with multiple paths.

Space concerns should be resolved by allowing user to customize what to see on status bar. I would remove Attachments from there right away - it is the most useless piece on status bar in my opinion.

And on top of that it would be good to have ability always show pieces you have chosen. I prefer stable static information even with zero counts instead of pieces jumping left and right as you go through your notes.