Millisecond time and backoff fix, the third time is the charm? #1067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using sample rate and channels to derive the length of the file. 2038 proofed ms timestamps. change from long long to int64
Call_Data_t Call_Concluder::create_call_data should now be more efficient and have more accurate lengths for ms and s both. add get_start_time_ms to call_impl so we can get the start_time_ms in call_concluder.cc filename is now seconds.ms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets try this yet again. These changes should ONLY be the ms_time portion of the previous pull request. This leaves existing timestamps in the metadata json and adds new keys for MS timestamps.
It also changes the file name when saved to include the timestamp in ms when the call started. This is due to a bit of a hacky way of adding +1 sec to avoid collisions for filenames. Now collisions should not happen.
"start_time": 1759627129,
"stop_time": 1759627132,
"start_time_ms": 1759627129115,
"stop_time_ms": 1759627137005,
file name format: we add a .xxx after the initial timestamp
300-1763759979.250_155415000.0-call_6.wavDoing this would be a step towards more accurate and precise timestamps. Which help in post processing scripts outside of trunk-recorder for detecting duplicate/simulcast calls for analog, or a setup where there are multiple nodes in different locations for the same radio system.
Exponential backoff fixed using XOR instead of wrong symbol. This should now doa proper back off and retry on failed call workers after call is finished.
long backoff = ((1 << call_info.retry_attempt) * 60) + jitter;