Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

New regex for subreddit and user group detection #17

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

mvietri
Copy link

@mvietri mvietri commented Jan 14, 2019

Before

Submission | Comment

post_before comment_before

After

Submission | Comment
post_after comment_after

  • Testing

@saket
Copy link

saket commented Jan 14, 2019

This is nice.

However, I'd like to point out that parsing markdown inside the app was a bad idea because markdown on Reddit is a gigantic pile of broken markdown syntaxes. I tried correcting some of them in the app, but it is unfortunately like a losing battle.

I'll switch back to using the "processed" markdown that Reddit sends. I've created an issue in the OG repository to track this:

saket#8

@mvietri
Copy link
Author

mvietri commented Jan 14, 2019

However, I'd like to point out that parsing markdown inside the app was a bad idea because markdown on Reddit is a gigantic pile of broken markdown syntaxes. I tried correcting some of them in the app, but it is unfortunately like a losing battle.

Markdown as you type on a reply is pretty heavy on the UI but works just fine. I think that with a little of optimization it could work a way faster than now.

This regex replacements are fast and don't need much more work.

@saket
Copy link

saket commented Jan 14, 2019

Ohh I wasn't referring to the markdown editor, but markdown for submission and comments.

@mvietri mvietri changed the title [WIP] New regex for subreddit and user group detection New regex for subreddit and user group detection Jan 15, 2019
@mvietri
Copy link
Author

mvietri commented Jan 15, 2019

I have no issues with this. All links I saw both user and subreddit where parsed correctly.

@mvietri
Copy link
Author

mvietri commented Jan 15, 2019

Ohh I wasn't referring to the markdown editor, but markdown for submission and comments.

Ahh ok!. Yeah markdown should be revise but for now we can push this to master to avoid false subreddits being treated as links.

@Tunous Tunous merged commit fa39576 into Tunous:master Apr 9, 2019
@Tunous Tunous added this to the 0.7.0 milestone Aug 10, 2019
@Tunous Tunous added the bug Something isn't working label Aug 10, 2019
@mvietri mvietri deleted the fix/subreddit-user-regex branch August 13, 2019 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants