Made a Geolocation extension #1943
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: new extension
|
This is pretty simple, I will give it a review later today if I don't forget |
Thanks! |
|
|
|
Here ! It's finally done! |
| "use strict"; | ||
|
|
||
| function getGeolocation( | ||
| options = { enableHighAccuracy: true, timeout: 5000, maximumAge: 0 } |
There was a problem hiding this comment.
I'm not familiar with geolocation apis but will the timeout affect anything?
Comment on lines
+159
to
+171
| async getCurrent(args) { | ||
| if (!(await this.isAllowed())) return ""; | ||
| var coordinates = await getGeolocation(); | ||
| if (coordinates.success == true) { | ||
| return coordinates[args.WHAT]; | ||
| } else { | ||
| return ""; | ||
| } | ||
| } | ||
|
|
||
| async isAllowed() { | ||
| return await Scratch.canGeolocate(); | ||
| } |
There was a problem hiding this comment.
@yuri-kiss are we allowed to make block functions themselves asynchronous or should we put asynchronous functions inside them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, folks!
I made a Geolocation extension.
Enjoy!