-
Notifications
You must be signed in to change notification settings - Fork 286
SAM extension #2032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SAM extension #2032
Conversation
Does he only know how to speak English? |
My bad. I didn't understand how to run linting and formatting, but I think I get it now. I'll try to fix all the issues ASAP. |
Alright, I fixed all of the errors. |
Hi @MagentaDude SAM is a lot of fun! I forked your repo and made 3 commits that you're welcome to include or ignore:
@WAYLIVES |
@lselden Those features sound great! I can't seem to find your fork though; could you provide a link? |
Whoops! Yeah it's here: https://github.com/lselden/extensions/tree/sam |
@MagentaDude I submitted a PR to your fork the plugs the leak, as well as including the other changes I suggested. Take from it what you will |
Looks great; I think I'll stop adding changes now 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code appears to be minified in some areas. Please use clear, well-formatted code.
!format |
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
Minified libraries aren't banned, so long as you include a license above, and it's recommended to use This extension relies on SAM.js and large libraries are probably better left minified |
I'm glad this project is finally out of limbo 😅 @PPPDUD Do you still want me to include the unminified version instead? |
It's fine, nevermind. I was feeling like picking apart PRs that day. |
This is a new extension that I've been working on the past few days that implements the program SAM (Software Automatic Mouth) into TurboWarp using SamJs. It allows the user to change the speed, pitch, mouth, and throat properties of the voice, which allows for more complex voices and text-to-speech in projects. It also has a nice retro vibe to it which would be great for projects simulating computers. Let me know what you think!