-
-
Notifications
You must be signed in to change notification settings - Fork 270
cursor.js -- translate cursor menu #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are going to do this preferably add an index for each item like native scratch, so people who dont know english (or the right value cause you changed the naming) can still use the block effectively.
that or we need to make a new block and use a field instead
done |
!format |
The formatting bot didn't find any formatting issues. It currently only checks the extensions folder. The author or a maintainer can run terminal command 'npm run format' manually to format all files. |
GarboMuffin in #1987:
The current names are meant to parody those used in the CSS "cursor" attribute. These names are not localized to any language except English, and so there's not really a reason to translate them unless we plan to change the names to make them more descriptive. I don't see anything wrong with doing so. |
"ns-resize", | ||
"nesw-resize", | ||
"nwse-resize", | ||
{ text: Scratch.translate("(1) default"), value: "default" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think numbers will work here so we shouldn't suggest people to put numbers in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay so just revert to the last commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preferably find a way to make the numbers work, as the issue stated in #2076 (review) still applies. probably would need to create a new block and hide the old version, since swapping from string values to indexes would change the extension's core functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preferably find a way to make the numbers work, as the issue stated in #2076 (review) still applies. probably would need to create a new block and hide the old version, since swapping from string values to indexes would change the extension's core functionality
talk to garbo about it. Im not going back and forth with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preferably find a way to make the numbers work, as the issue stated in #2076 (review) still applies. probably would need to create a new block and hide the old version, since swapping from string values to indexes would change the extension's core functionality
or just support both
Resolves: #1987
I changed some naming or cursors, lmk if some others should be changed as well...