Add Modals Extension #2095

scratch-craft-2 · 2025-04-26T18:14:33Z

https://github.com/scratch-craft-2/extensions/tree/master

Brackets-Coder · 2025-04-26T18:16:46Z

You'll want to do this in a separate branch so it's not in the master branch. Inside your fork of Turbowarp/extensions, you should have one branch per extension so it's easier to manage pull requests. When you're done that I might give it a review if I have time.

scratch-craft-2 · 2025-04-26T18:22:58Z

Вы должны сделать это на отдельной ветке, чтобы она не была на главной ветке. Внутри вашей вилки Turbowarp/расширений у вас должна быть одна ветка расширения, чтобы было проще управлять запросами на извлечение. Когда вы это сделаете, я, возможно, сделаю обзор, если у меня будет время.

I don't really understand you... I kind of did everything, entered what was needed, he wrote the code on a separate repository, in all the necessary folders. well, the code went a little wrong and the bot didn't pass, but I've changed it now. please add an extension, I tried very hard.
if something is wrong, tell me what needs to be changed.

scratch-craft-2 · 2025-04-26T18:38:34Z

You'll want to do this in a separate branch so it's not in the master branch. Inside your fork of Turbowarp/extensions, you should have one branch per extension so it's easier to manage pull requests. When you're done that I might give it a review if I have time.

I kindly ask you to restart the bot check and tell me exactly what I need to do.

scratch-craft-2 · 2025-04-26T20:22:37Z

You'll want to do this in a separate branch so it's not in the master branch. Inside your fork of Turbowarp/extensions, you should have one branch per extension so it's easier to manage pull requests. When you're done that I might give it a review if I have time.
Have I fixed the errors in the code, when will the bot recheck the code?, and please explain exactly what I should do, I really don't know English.

scratch-craft-2 · 2025-04-26T20:26:10Z

should I delete the folder and get the file from it, or what should I do?

You'll want to do this in a separate branch so it's not in the master branch. Inside your fork of Turbowarp/extensions, you should have one branch per extension so it's easier to manage pull requests. When you're done that I might give it a review if I have time.

yuri-kiss

images should try to not contain any text as it is nearly impossible to translate.

everything in this extension already exists in a multitude of other extensions on the gallery so it has little to 0 chance of being merged, sorry.

aside from this run prettier

extensions/Scratch_craft_2/modals.js

@@ -0,0 +1,72 @@
+// Name: Modals
+// ID: htmlalert


extensions/Scratch_craft_2/modals.js

@@ -0,0 +1,72 @@
+// Name: Modals
+// ID: htmlalert
+// Description: This extension adds modal dialog boxes.


extensions/Scratch_craft_2/modals.js

+      getInfo() {
+        return {
+          id: "htmlalert",
+          name: "modals",


extensions/Scratch_craft_2/modals.js

+            {
+              opcode: "alertb",
+              blockType: Scratch.BlockType.COMMAND,
+              text: "alert [textia]",


extensions/Scratch_craft_2/modals.js

+      getInfo() {
+        return {
+          id: "htmlalert",
+          name: "modals",


extensions/Scratch_craft_2/modals.js

+           { 
+              opcode: "Confirmb",
+              blockType: Scratch.BlockType.BOOLEAN,
+              text: "confirm [textic]",


extensions/Scratch_craft_2/modals.js

+          {
+              opcode: "Promptb",
+              blockType: Scratch.BlockType.REPORTER,
+              text: "prompt [textip], default value: [classic]",


extensions/Scratch_craft_2/modals.js

+        };
+      }
+alertb(args) {
+ alert([args.textia]);


PPPDUD

You watermarked the console logs with your username‽ What would happen if someone else cleaned up your code in the future? You would be hogging all the credit up!

Brackets-Coder

This probably won't be merged since it's functionality can somewhat be recreated with either existing extensions or ones in existing PRs, but I'm going to need @CubesterYT to probably take a look.

Overall add translate and follow TW best practices, also needs to be in a separate branch and not the master branch

This is just a quick skim review so let me know if I missed anything.

Brackets-Coder · 2025-09-13T14:52:16Z

extensions/Scratch_craft_2/modals.js

@@ -0,0 +1,72 @@
+// Name: Modals
+// ID: htmlalert


This needs to contain your username

Suggested change

// ID: htmlalert

// ID: scratchCraftHTMLAlert

Brackets-Coder · 2025-09-13T14:52:44Z

extensions/Scratch_craft_2/modals.js

+    class modals {
+      getInfo() {
+        return {
+          id: "htmlalert",


ID needs to match the one at the top and contain a username

Suggested change

id: "htmlalert",

id: "scratchCraftHTMLAlert",

extensions/Scratch_craft_2/modals.js

Brackets-Coder · 2025-09-13T14:54:46Z

extensions/Scratch_craft_2/modals.js

+alertb(args) {
+ alert([args.textia]);
+}
+Promptb(args) {
+  return prompt([args.textip], [args.classic]);
+}
+Confirmb(args) {
+  return confirm([args.textic]);
+}


Arguments should use Scratch.cast, also why are you wrapping all of them in square brackets?

Brackets-Coder · 2025-09-13T14:55:04Z

images/Scratch_craft_2/modals.png

This shouldn't contain text, it can't be translated.

Co-authored-by: Brackets-Coder <[email protected]>

CubesterYT · 2025-09-14T18:48:10Z

Yeah this PR should be closed

scratch-craft-2 added 12 commits April 26, 2025 20:17

Create alert()_in_turbowarp

93d6b5b

Create hello

14efeb7

Add files via upload

69296f6

Delete images/Scratch_craft_2/hello

fd0c255

Rename Без названия (3).png to modals.png

4f573e5

Rename alert()_in_turbowarp to modals.js

fe764e6

Update modals.js

932581b

Update extensions.json

f9f8c3d

Delete images/Scratch_craft_2/modals.png

62769de

Create h

05d7e92

Add files via upload

a837679

Delete images/Scratch_craft_2/h

67d86b5

github-actions bot added the pr: new extension Pull requests that add a new extension label Apr 26, 2025

Update README.md

f428e91

Update modals.js

9a2b700

scratch-craft-2 added 2 commits April 26, 2025 21:25

Update modals.js

45163e7

Update modals.js

e0790aa

Update modals.js

1cadd75

Update modals.js

761b2f1

Update modals.js

d721812

scratch-craft-2 mentioned this pull request Apr 27, 2025

please consider my request to add an extension. #2096

Closed

scratch-craft-2 added 3 commits April 27, 2025 14:59

Update modals.js

64387ae

Update modals.js

d409ce7

Update modals.js

1aa3d0f

yuri-kiss suggested changes Apr 29, 2025

View reviewed changes

This comment was marked as abuse.

Sign in to view

PPPDUD reviewed Jun 29, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

PPPDUD self-assigned this Sep 13, 2025

PPPDUD requested a review from Brackets-Coder September 13, 2025 14:22

Brackets-Coder requested changes Sep 13, 2025

View reviewed changes

Brackets-Coder changed the title ~~Created the mondals extension. I want to add it to the turbowarp extension library.~~ Add Modals Extension Sep 13, 2025

Update extensions/Scratch_craft_2/modals.js

1861c38

Co-authored-by: Brackets-Coder <[email protected]>

Brackets-Coder closed this Sep 14, 2025

Add Modals Extension #2095

Add Modals Extension #2095

Conversation

scratch-craft-2 commented Apr 26, 2025

Uh oh!

Brackets-Coder commented Apr 26, 2025

Uh oh!

scratch-craft-2 commented Apr 26, 2025

Uh oh!

scratch-craft-2 commented Apr 26, 2025

Uh oh!

scratch-craft-2 commented Apr 26, 2025

Uh oh!

scratch-craft-2 commented Apr 26, 2025

Uh oh!

yuri-kiss left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

Uh oh!

This comment was marked as abuse.

PPPDUD left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Brackets-Coder left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Brackets-Coder Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

Brackets-Coder Sep 13, 2025

Choose a reason for hiding this comment

Uh oh!

CubesterYT commented Sep 14, 2025

Uh oh!

Uh oh!

yuri-kiss left a comment •

edited

Loading

PPPDUD left a comment •

edited

Loading

Brackets-Coder left a comment •

edited

Loading