Add parsing support to vercte/dictionaries.js for convenience #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr: change existing extension
Member
|
!format |
Member
|
Please do not use |
Collaborator
not deprecated, just not needed for this repo, as the build process adds it automatically. i think what happened is that you pasted the code directly from extensions.turbowarp.org/vercte/dictionaries.js instead of the source code, which includes said generated Scratch.translate.setup calls. |
GarboMuffin
reviewed
Nov 29, 2025
extensions/vercte/dictionaries.js
Outdated
| // ID: verctedictionaries | ||
| // Description: Use the power of dictionaries in your project. | ||
| // By: Vercte <https://scratch.mit.edu/users/lolecksdeehaha/> | ||
| // By: Vercte <https://scratch.mit.edu/users/lolecksdeehaha/>, LSPECTRONIZTAR <https://scratch.mit.edu/users/LSPECTRONIZTAR/> |
Member
There was a problem hiding this comment.
Comma won't work. Need second line
Contributor
|
!format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made it so that the
parse JSON intoblock (now renamed toset to JSON) can support parsed JSON objects and thestringifyblock (now renamed toget as JSON) can also return parsed objects if the project creator wishes (for speed-increasing purposes). However, the return option is set tostringifiedby default to stay true to the old version.I also added to the
Scratch.translate.setupfor the new blocks and made sure that the extension update is completely compatible with any projects that might use the previous version.Please I need this so my 3D physics engine won't lag 🙏