-
Notifications
You must be signed in to change notification settings - Fork 314
New extension: Volumes (previously CobaltVDisk) #2369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
@kx1bx1 please stop generating and submitting AI-generated extensions to the gallery (note: this is my personal opinion; see #2260 or maybe see if @GarboMuffin has anything to say) Edit: just thought about this comment again and it feels plain rude; but your extension does not contain any actual code; just a few comments. I have read the comment explaining this in your code, but IMO you should only make a PR when your extension somewhat works (the mesh PR I recently made in #2382 does somewhat work because messages are indeed being sent over the broadcastchannel, but the hat block doesn't work due to fields vs inputs.) |
Yes, this PR does not have any actual code. The reason I haven’t posted the source yet is personal, and a PR isn’t a good venue for that, so I’ll omit it here. I agree that PRs should be reviewable and functional, and I’ll share Volumes’ source once it’s ready to demonstrate working behavior. If LLM-generated code is ever used, and I've said it before, it should meet or exceed human standards. |
|
If you have no code that you want reviewed then you shouldn't make the pull request yet |
|
GitHub should let you make a new pull request for when you have something to get looked at |
as per CONTRIBUTING.md you can use MPL-2.0 instead, which is a good balance, though this is not enforced |
I might do either GPL-3.0 or MPL-2.0; if I can't choose, I might as well do a coin flip. |
Note: For some reason, Canva's SVGs can't render properly, so I had to export them as PNGs.
Volumes is an enhancement of
rxFSby 0832. Its main focus is speed improvements and new features like file size limits, permissions, and more.The versioning scheme
Volumes go by a '3-monthly' update schedule. If any changes to Volumes were made by me, a PR will be made as a 'cumulative update' to Volumes. As of right now, Volumes' versioning schema has been removed, as its target audience probably does not care what version Volumes is on.
Why use the MIT license?
My choice of using the MIT license instead of the GPL-3.0 license is not only due to brevity, but also due to the fact that I want Volumes to be aligned with TurboWarp’s existing ecosystem and extension practices. MIT is rather open and easy to understand for users, and it's quite permissive, so that's what I used.
Full disclosure: this extension was LLM-generated
This extension's code is purely LLM-generated. When I say this, I do not mean I only generated it in one prompt. I bring my models to a high standard, and you could probably count 50 prompts that assess security, stability, and speed with Volumes. If AI-generated code is used, it should meet or exceed human-quality standards.
I do intend to do the 'ultimate test' of Volumes by creating a project that primarily uses it, to ensure I can mark this PR ready to review.
Why so few commits?
This PR is planned to only have 5-10 commits because one commit is supposed to be one Volume update after development is finished. This PR will be squashed or rebased once development is complete.
About this PR
Planned features