-
Notifications
You must be signed in to change notification settings - Fork 46
Allow ADTypes AD backend selection in Hamiltonian #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
e009707
Allow ADTypes AD backend selection in Hamiltonian
ErikQQY 2a0a36f
Merge branch 'main' into qqy/adtypes
ErikQQY 9ae9914
Apply reviews
ErikQQY 67c8756
Merge branch 'main' into qqy/adtypes
ErikQQY e5c5a76
Merge branch 'main' into qqy/adtypes
ErikQQY 6d334c8
Fix CI failings
ErikQQY c1c7856
Integrate DifferentiationInterface
ErikQQY 8cbbc3a
Fix typos and remove LDPAD from deps
ErikQQY abb67eb
Lets only focus on adtypes
ErikQQY 1060e7d
Fix some typos
ErikQQY 3f33d3c
Remove default AD choose
ErikQQY 6e1af0d
Misc
ErikQQY 0fdf9ac
Also test when provided as LogDensityModel
ErikQQY 0958515
Dont forget other dependencies for ADTypes ext
ErikQQY 7b63145
Proper using
ErikQQY a89cf2f
Proper using
ErikQQY File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
module AdvancedHMCADTypesExt | ||
|
||
using AdvancedHMC: | ||
AbstractMetric, LogDensityModel, Hamiltonian, LogDensityProblems, LogDensityProblemsAD | ||
using ADTypes: AbstractADType | ||
|
||
function Hamiltonian( | ||
metric::AbstractMetric, ℓπ::LogDensityModel, kind::AbstractADType; kwargs... | ||
) | ||
return Hamiltonian(metric, ℓπ.logdensity, kind; kwargs...) | ||
end | ||
function Hamiltonian(metric::AbstractMetric, ℓπ, kind::AbstractADType; kwargs...) | ||
if LogDensityProblems.capabilities(ℓπ) === nothing | ||
throw( | ||
ArgumentError( | ||
"The log density function does not support the LogDensityProblems.jl interface", | ||
), | ||
) | ||
end | ||
ℓ = LogDensityProblemsAD.ADgradient(kind, ℓπ; kwargs...) | ||
return Hamiltonian(metric, ℓ) | ||
end | ||
|
||
end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.