Skip to content

Fix gradient length mismatch in PhasePoint #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix gradient length mismatch in PhasePoint #426

wants to merge 1 commit into from
+10 −2

Conversation

ErikQQY
Copy link
Collaborator

@ErikQQY ErikQQY commented Apr 13, 2025

Part of #344

@ErikQQY ErikQQY mentioned this pull request Apr 13, 2025
Open
@ErikQQY
Copy link
Collaborator Author

ErikQQY commented Apr 13, 2025

Hmmm, seems there might be some code relying on this issue, need further investigation

@yebai yebai requested a review from sunxd3 April 17, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yebai yebai yebai approved these changes

@sunxd3 sunxd3 Awaiting requested review from sunxd3

Assignees

@ErikQQY ErikQQY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikQQY @yebai