Reduce allocation in mass matrix adaptor #427
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yebai
reviewed
Apr 17, 2025
devmotion
reviewed
Apr 18, 2025
| @@ -102,20 +102,50 @@ function WelfordVar(sz::Union{Tuple{Int},Tuple{Int,Int}}; kwargs...) | |||
| return WelfordVar{Float64}(sz; kwargs...) | |||
| end | |||
|
|
|||
| function Base.resize!(wv::WelfordVar, θ::AbstractVecOrMat{T}) where {T<:AbstractFloat} | |||
| if size(θ) != size(wv.var) | |||
| function Base.resize!(wv::WelfordVar, θ::AbstractMatrix{T}) where {T<:AbstractFloat} | |||
There was a problem hiding this comment.
IMO this function must be renamed, it's a misuse of Base.resize! as the second argument of resize! is supposed to be an integer. It should just be an internal function.
devmotion
reviewed
Apr 18, 2025
| n = length(θ) | ||
| if n != size(wv.var, 1) | ||
| @assert wv.n == 0 "Cannot resize a var estimator when it contains samples." | ||
| __resize_fill!(wv.μ, n, T(0)) |
There was a problem hiding this comment.
I don't really see the need for a custom function, it seems this is just
Suggested change
| __resize_fill!(wv.μ, n, T(0)) | |
| fill!(resize!(wv.μ, n), T(0)) |
devmotion
reviewed
Apr 18, 2025
Comment on lines
+136
to
+140
| if length_diff > 0 | ||
| append!(x, Vector{T}(undef, length_diff)) | ||
| else | ||
| resize!(x, new_length) | ||
| end |
There was a problem hiding this comment.
Both branches seem to be just
Suggested change
| if length_diff > 0 | |
| append!(x, Vector{T}(undef, length_diff)) | |
| else | |
| resize!(x, new_length) | |
| end | |
| resize!(x, new_length) |
? As mentioned above, in that case fill!(resize!(..), ..) would be simpler than a separate function IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allocating using
zerosandoneswhen resizing the adaptor, we can directly use in-place operations likeresize!andfill!to reduce allocations.