Skip to content

Remove custom poislogpdf for ForwardDiff.Dual #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 26, 2021
Merged

Remove custom poislogpdf for ForwardDiff.Dual #160

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7e9582c
Fix ForwardDiff of poislogpdf at v of zero
oschulz Apr 18, 2021
9d04524
Improve poislogpdf with ForwardDiff
oschulz Apr 19, 2021
6525183
Remove custom poislogpdf for ForwardDiff.Dual
oschulz Apr 19, 2021
850363c
Bump version
devmotion Apr 19, 2021
8b19610
Merge branch 'master' into diff-poislogpdf
devmotion Apr 19, 2021
2a17639
Mark tests as broken
devmotion Apr 21, 2021
73d804c
Mark more tests as broken
devmotion Apr 21, 2021
07ad0f6
Tests only broken on Julia 1.3?
devmotion Apr 21, 2021
dd72f25
Merge branch 'master' into diff-poislogpdf
devmotion Apr 25, 2021
01781ca
Revert changes
devmotion Apr 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/forwarddiff.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,6 @@ function binomlogpdf(n::Int, p::ForwardDiff.Dual{T}, x::Int) where {T}
end


## Poisson

function poislogpdf(v::ForwardDiff.Dual{T}, x::Int) where {T}
FD = ForwardDiff.Dual{T}
val = ForwardDiff.value(v)
Δ = ForwardDiff.partials(v)
return FD(poislogpdf(val, x), Δ * (x/val - 1))
end


## Integer dual ##

function BetaBinomial(n::ForwardDiff.Dual{<:Any, <:Integer}, α::Real, β::Real; check_args = true)
Expand Down