-
Notifications
You must be signed in to change notification settings - Fork 16
New landing page design #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview the changes: https://turinglang.org/pr-previews/119 |
If anyone is interested, then please feel free to take on this PR! |
* very basic redesign * make buttons interactive
* add dangling code example * add code example section
* quickfix alignment * add news and clean up scss
* improve colors * better link hover color
* paste in svg * responsive svg header
using the same background colour for the team "cards" as for the non-hoverable cards on the landing page
- added links to discourse and slack to the buttons at the top of the page - moved link to libraries page to "Learn more" section
Co-authored-by: Penelope Yong <[email protected]>
0046a57
to
e9e14d5
Compare
I will definitely have time to finish this in July. Which points would you like to see addressed before this PR can be merged? |
Revisiting this. Is there a reason why the old PR was closed? Also, I'd personally be happy to merge if some of the placeholder content is removed. Honestly, it's not like the existing front page has any resources, so even a fairly clean slate would be a huge improvement over the current one. |
@simonsteiger Let's merge it, can you please review it once more before merging! |
@simonsteiger, These might help -- https://quarto.org/docs/output-formats/html-themes.html#code-blocks and this: turinglang.github.io/_quarto.yml Line 56 in 9f043c6
|
I'll work on the docs PR (TuringLang/docs#613) now and should be done my tomorrow morning at the latest. I really like the changes to the landing page so far; the new example and the "Get Started" panel left of it looks awesome. |
Thanks for pointing that out! I also find the hover effect on the code block a bit off compared to the other elements. I’m happy to remove it, already done! |
Thank you, @simonsteiger! Let’s merge both PRs tomorrow then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through the most recent changes and browsed the landing page once again in both light and dark mode. Everything looks great! Awesome work, I am looking forward to seeing the new website live!
* Updated theme-colors to match main site for consistency * fixed search results color in dark mode * fix copy button css in dark mode * search bar background udpdate * removed current default footer and added custom one * Add custom footer and update styles to match TuringLang/turinglang.github.io#119 * Update styles to match original site * cleanup code * Added SCSS styles to match main site * Add all icons in navbar + match few tweaks with main PR * Enable Open Graph and Twitter Cards for SEO * fix corrupted png * remove old styles --------- Co-authored-by: Penelope Yong <[email protected]>
Thanks so much @simonsteiger for all your help — couldn't have done it this well without you! |
Thank you @penelopeysm and @yebai! Let me know if anything else is required to add, I will add them in other PRs, also let's do this someday -- #76 |
The result looks great, thanks @shravanngoswamii! |
Continuing #105
Preview the changes: https://turinglang.org/pr-previews/119