Open
Conversation
tbuchaillot
requested changes
Oct 5, 2023
Collaborator
tbuchaillot
left a comment
There was a problem hiding this comment.
Found a big problem with this approach - we actually need multiple HTTP handler for each API since we are setting different attributes for each handler ( like api_id, org_id, etc).
We need to continue investigating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now we're using a Singleton to generate new HTTP handlers. This will help us to avoid memory leaks due to the multiple creation of http.Handler objects.
Related Issue
https://tyktech.atlassian.net/browse/TT-10153?atlOrigin=eyJpIjoiYmY2YzE3OWNhNjE2NDliMGI3YmQzYTU4YTU0ZDdhMTEiLCJwIjoiaiJ9
Motivation and Context
https://community.tyk.io/t/increasing-memory-usage-after-5-2-upgrade/6731
Test Coverage For This Change
Screenshots (if appropriate)
Types of changes
Checklist
master!masterbranch (left side). Also, it would be best if you started your change off our latestmaster.go mod tidy && go mod vendorgofmt -s -w .go vet ./...