Added minimal_quotes feature #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avaScript notation (mongosh style), rather than JSON, meaning that { _id:1, name:bob, height:180 } is displayed like this { _id:1, name:bob, height:180 } which is easier for humans to read.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
When enabled, we will quote strings as minimally as possible.
So when a string doesn't contain
'then we quote with single quotes.If it contains
'but not"then we quote with double quotes.If a string contains single and double quotes, we quote with single quotes.
Testing
I ran
make installand ran a few queries with some test data.mongoshellScreenshots
javascript_keys:true, minimal_quotes:falsejavascript_keys:true, minimal_quotes:true