Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
nperez0111
reviewed
Oct 27, 2025
Comment on lines
+477
to
+478
| // TODO | ||
| throw new Error(`todo`); |
Collaborator
Author
There was a problem hiding this comment.
Since this case is for deleting columns/column lists, I'd rather wait until #2110 is merged before fixing this.
nperez0111
requested changes
Oct 29, 2025
Contributor
nperez0111
left a comment
There was a problem hiding this comment.
Will hold on this until we get that PR through
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some additional handling for the Delete key that already exists for the Backspace key.
Rationale
MacOS keyboards don't relaly have a delete key, but Windows keyboards do and it's a fairly commonly used key, so it makes sense to have better support for it.
Changes
getNextBlockInfohelper.Impact
N/A
Testing
TODO? We also have pretty limited tests for Backspace handling. I'm a bit hesitant to add them though as they would currently have to be e2e tests, so would prefer to set up component testing first.
Screenshots/Video
N/A
Checklist
Additional Notes