This repository was archived by the owner on Jun 29, 2023. It is now read-only.
Improve travis execution time #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondobson
force-pushed
the
improve-travis-execution-time
branch
from
78299be to
09ffb81
Compare
javigomez
reviewed
Oct 4, 2017
.travis.yml
Outdated
| bundler: true | ||
| directories: | ||
| - /home/travis/.rvm/ |
There was a problem hiding this comment.
mmm, doesn't seem to work for Ruby installation
Before caching:
After caching:
javigomez
reviewed
Oct 4, 2017
|
|
||
| cache: | ||
| bundler: true |
There was a problem hiding this comment.
This one does the trick:
Before:
After:
javigomez
reviewed
Oct 4, 2017
simondobson
force-pushed
the
improve-travis-execution-time
branch
6 times, most recently
from
c1ab9fa to
013fe16
Compare
added 2 commits
October 4, 2017 19:45
simondobson
force-pushed
the
improve-travis-execution-time
branch
from
013fe16 to
59c5a32
Compare
|
I think travis fails because you haven't added rubocop to the Gemfile https://github.com/Typeform/create-api-gem/blob/master/Gemfile |
|
Really weird, it's still not working :( |
javigomez
reviewed
Oct 16, 2017
.travis.yml
Outdated
| bundler: true | ||
|
|
||
| script: rubocop && rake test |
There was a problem hiding this comment.
try this:
script:
bundle exec rubocop
bundle exec rake test
|
Yes! Working again :) - thanks @javigomez |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16 and #17