Adjust slider bounds for day/night temperature dynamically, based on …

…the current values (#312)
Tyrrrz · May 31, 2024 · 5d72dd6 · 5d72dd6
1 parent 6c7d8bc
commit 5d72dd6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/LightBulb/Behaviors/LostFocusUpdateBindingBehavior.cs b/LightBulb/Behaviors/LostFocusUpdateBindingBehavior.cs
@@ -59,7 +59,7 @@ private void OnLostFocus(object? sender, RoutedEventArgs e)
 
     private void OnBindingValueChanged()
     {
-        if (AssociatedObject != null)
+        if (AssociatedObject is not null)
             AssociatedObject.Text = Text;
     }
 }
diff --git a/LightBulb/ViewModels/Components/Settings/GeneralSettingsTabViewModel.cs b/LightBulb/ViewModels/Components/Settings/GeneralSettingsTabViewModel.cs
@@ -7,6 +7,12 @@ namespace LightBulb.ViewModels.Components.Settings;
 public class GeneralSettingsTabViewModel(SettingsService settingsService)
     : SettingsTabViewModelBase(settingsService, 0, "General")
 {
+    // This value is used for slider bounds, but it's not an actual restriction
+    public double RecommendedMaximumDayTemperature => Math.Max(6600, DayTemperature);
+
+    // This value is used for slider bounds, but it's not an actual restriction
+    public double RecommendedMinimumDayTemperature => Math.Min(2500, DayTemperature);
+
     public double DayTemperature
     {
         get => SettingsService.DayConfiguration.Temperature;
@@ -26,6 +32,12 @@ public double DayTemperature
         }
     }
 
+    // This value is used for slider bounds, but it's not an actual restriction
+    public double RecommendedMaximumNightTemperature => Math.Max(6600, NightTemperature);
+
+    // This value is used for slider bounds, but it's not an actual restriction
+    public double RecommendedMinimumNightTemperature => Math.Min(2500, NightTemperature);
+
     public double NightTemperature
     {
         get => SettingsService.NightConfiguration.Temperature;

diff --git a/LightBulb/Views/Components/Settings/GeneralSettingsTabView.axaml b/LightBulb/Views/Components/Settings/GeneralSettingsTabView.axaml
@@ -24,8 +24,8 @@
             Margin="0,12,0,0"
             IsSnapToTickEnabled="True"
             LargeChange="500"
-            Maximum="6600"
-            Minimum="2500"
+            Maximum="{Binding RecommendedMaximumDayTemperature}"
+            Minimum="{Binding RecommendedMinimumDayTemperature}"
             SmallChange="100"
             TickFrequency="20"
             Value="{Binding DayTemperature}" />
@@ -47,8 +47,8 @@
             Margin="0,12,0,0"
             IsSnapToTickEnabled="True"
             LargeChange="500"
-            Maximum="6600"
-            Minimum="2500"
+            Maximum="{Binding RecommendedMaximumNightTemperature}"
+            Minimum="{Binding RecommendedMinimumNightTemperature}"
             SmallChange="100"
             TickFrequency="20"
             Value="{Binding NightTemperature}" />