fix: handle missing dataset files without traceback (#110)#201
Open
cmw-creator wants to merge 3 commits into
Open
fix: handle missing dataset files without traceback (#110)#201cmw-creator wants to merge 3 commits into
cmw-creator wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #110
This change converts missing dataset files during extraction into a clean CLI error instead of allowing the
FileNotFoundErrorfrom xarray/h5netcdf to surface as a traceback.It handles both places mentioned in the issue:
drop_varssetxarray.open_mfdataset()call over the full dataset path listTest plan
pytest -q tests/core/test_extract.py::TestOpenDatasetMissingFiles::test_missing_first_dataset_path_exits_cleanlypytest -q tests/core/test_extract.py::TestOpenDatasetMissingFiles tests/core/test_extract.py::TestCliExtract::test_no_config_file tests/core/test_extract.py::TestCliExtract::test_cli_extractpython -m compileall -q reshapr/core/extract.py tests/core/test_extract.py