Skip to content

Add Pylint GitHub Action#76

Open
joseph784 wants to merge 11 commits into
UBC-Rocket:masterfrom
joseph784:pylint
Open

Add Pylint GitHub Action#76
joseph784 wants to merge 11 commits into
UBC-Rocket:masterfrom
joseph784:pylint

Conversation

@joseph784

Copy link
Copy Markdown

No description provided.

@Green-Avocado Green-Avocado left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread .github/workflows/pylint.yml Outdated
Co-authored-by: Jason Ngo <greenavocado@protonmail.com>
@DSep DSep requested a review from SilentSys November 11, 2021 02:37

@SilentSys SilentSys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. So is this going to start working once it gets merged into master or do we need to set up an account or give something access to this repo?

Also wondering if it would be worth consolidating this into CircleCI so that we don't have to maintain two different CI services.

Comment thread .github/workflows/pylint.yml Outdated

@Green-Avocado Green-Avocado left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid running pylint on unchanged files

Comment thread .github/workflows/pylint.yml
Comment thread .github/workflows/pylint.yml Outdated
Comment thread .github/workflows/pylint.yml Outdated
joseph784 and others added 2 commits December 5, 2021 13:10
Co-authored-by: Jason Ngo <greenavocado@protonmail.com>
Co-authored-by: Jason Ngo <greenavocado@protonmail.com>
Comment thread .github/workflows/pylint.yml Outdated
joseph784 and others added 2 commits February 6, 2022 02:15
Co-authored-by: Andrei Popescu <andy.pope.13@gmail.com>
Co-authored-by: Jason Ngo <greenavocado@protonmail.com>
@joseph784

Copy link
Copy Markdown
Author

Looks good. So is this going to start working once it gets merged into master or do we need to set up an account or give something access to this repo?

No setup is required, it should be good to go once it's in main

Also wondering if it would be worth consolidating this into CircleCI so that we don't have to maintain two different CI services.

I think this would be easier just doing it this way, but we could consolidate it if you want

@MarcoYuen17 MarcoYuen17 reopened this Feb 13, 2022
@DSep DSep mentioned this pull request Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants