Plots showing frequency of earthquake and average magnitudes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pete-R-Jones
changed the title
Pete-R-Jones
changed the title
ageorgou
reviewed
Nov 1, 2021
Comment on lines
+60
to
+63
| for indx, year in enumerate(years): | ||
| if get_year(earthquake) == year: | ||
| frequency[indx] +=1 |
There was a problem hiding this comment.
This could be simplified if you used a dictionary to map years to counts directly. That way you wouldn't need the inner loop of searching for the right year. Similarly for the loops below.
In general, nested loops like this can decrease performance because of the number of iterations they lead to, so try to avoid them when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-MPHY0021-21-22/RSE-Classwork#15
@kjhmh2