Answers for preliminary work #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ageorgou
reviewed
Nov 1, 2021
| ... | ||
| mags = [get_magnitude(quake) for quake in data] | ||
| max_value = max(mags) | ||
| index = mags.index(max_value) |
There was a problem hiding this comment.
What if there were more than one earthquakes with the same magnitude max_value? What would mags.index return then?
| mags = [get_magnitude(quake) for quake in data] | ||
| max_value = max(mags) | ||
| index = mags.index(max_value) | ||
| return [max_value, get_location(data[index])] |
There was a problem hiding this comment.
Since you know you will always be returning two items (the magnitude and location), you can also return a tuple, implicitly or explicitly:
return (max_value, get_location(data[index]))
# or
return max_value, get_location(data[index])Returning a list is by no means wrong, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-MPHY0021-21-22/RSE-Classwork#13
I initially found it difficult to read the file as I didn't realise it was already in a "json" format, so I was incorrectly using json.dumps. Once that was sorted it wasn't too bad and satisfying to see the result!
Output:
Loaded 120
The strongest earthquake was at [-2.15, 52.52] with magnitude 4.8