wrote code to pick out strongest earthquakes #3
Conversation
|
|
||
| data_asdict = json.loads(text) | ||
| with open('response.json', 'w') as file: | ||
| file.write(json.dumps(data_asdict, indent=4)) |
There was a problem hiding this comment.
Indeed, using indent=... makes for a much more readable file.
You can make the code a bit shorter by using json.dump, which will essentially do the same as dumps and then write.
| print(f"The strongest earthquakes were at coordinates of {max_location} with magnitude {max_magnitude}, There were two earthquakes with equal largest magnitude") |
There was a problem hiding this comment.
Good job spotting that there were two earthquakes with equal magnitude
| @@ -3,6 +3,8 @@ | |||
| # However, we will use a more powerful and simpler library called requests. | |||
| # This is external library that you may need to install first. | |||
| import requests | |||
| import yaml | |||
There was a problem hiding this comment.
I don't think you need this import here since you're not working with YAML!
| "The text is in dictionary format, under a string" | ||
| "get dictionary out using json" |
There was a problem hiding this comment.
It's good to write comments to explain what you're doing and why, as you do here and later, though note that in Python comment lines should start with a a # . You can leave multi-line comments enclosed in """...""", but those are best reserved for documenting functions etc ("docstrings").
|
|
||
| data_asdict = json.loads(text) | ||
| with open('response.json', 'w') as file: | ||
| file.write(json.dumps(data_asdict, indent=4)) |
There was a problem hiding this comment.
Indeed, using indent=... makes for a much more readable file.
You can make the code a bit shorter by using json.dump, which will essentially do the same as dumps and then write.
| "for each event, 'mag' key gives magnitude. 'place' key gives place name, but 'geometry' 'coordinates'" | ||
| "gives the coordinates of the location" | ||
| "The time of the earthquake claims to use the ISO8601 Date/Time format, but this doesn't appear true..." | ||
| "What does 'time'=956553055700 mean? Seconds since something?" |
There was a problem hiding this comment.
Hopefully this was clarified in the classwork exercise!
| index_of_max = [index for index, item in enumerate(magnitudes) if item == max_mag] | ||
| max_locs = locations[index_of_max[0]], locations[index_of_max[1]] |
There was a problem hiding this comment.
As said in another review, good job making this general enough to handle multiple earthquakes with the same magnitude.
Answers UCL-MPHY0021-21-22/RSE-Classwork#13
was useful to practice with json/yaml files.
Found two events with same max magnitude.