Constance - Answers UCL-MPHY0021-21-22/RSE-Classwork#13 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claine18
changed the title
CoreyFulop
reviewed
Oct 27, 2021
|
|
||
|
|
||
| def get_maximum(data): | ||
| """Get the magnitude and location of the strongest earthquake in the data.""" | ||
| ... | ||
| list_magnitude = [get_magnitude(earthquake) for earthquake in data["features"]] | ||
| list_location = [get_location(earthquake) for earthquake in data["features"]] |
There was a problem hiding this comment.
Really interesting to see list comprehensions put to use!
ageorgou
reviewed
Nov 1, 2021
| @@ -27,32 +28,38 @@ def get_data(): | |||
| # To understand the structure of this text, you may want to save it | |||
| # to a file and open it in VS Code or a browser. | |||
| # See the README file for more information. | |||
| ... | |||
| with open('response_web.json', 'w') as json_file: | |||
| json.dump(text, json_file, indent = 4) | |||
There was a problem hiding this comment.
Good idea to use the indent argument, which gives a more readable output file. But are you writing what you need here? (there may be a related question on Moodle)
| list_magnitude = [get_magnitude(earthquake) for earthquake in data["features"]] | ||
| list_location = [get_location(earthquake) for earthquake in data["features"]] | ||
| max_magnitude = max(list_magnitude) | ||
| max_location = list_location[list_magnitude.index(max_magnitude)] |
There was a problem hiding this comment.
Good! A question - what happens if there are two earthquakes with the same magnitude? What does list_magnitude.index return then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers UCL-MPHY0021-21-22/RSE-Classwork#13
I found powerful to convert string into a dictionary with the json package.
Result obtained :