EPP 160 Precursor details page #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/epp-amend/index.js
# Conflicts: # apps/epp-amend/fields/index.js # apps/epp-amend/index.js # apps/epp-amend/translations/src/en/fields.json # apps/epp-amend/translations/src/en/pages.json # apps/epp-amend/translations/src/en/validation.json
vivekkumar-ho
changed the title
# Conflicts: # apps/epp-amend/fields/index.js # apps/epp-amend/index.js # apps/epp-amend/translations/src/en/fields.json # apps/epp-amend/translations/src/en/validation.json
vivekkumar-ho
changed the title
vivekkumar-ho
requested review from
PaolaDMadd-Pro,
william-gu-hof and
MikeMaratheftis
vivekkumar-ho
commented
Feb 19, 2025
vivekkumar-ho
commented
Feb 19, 2025
|
The work looks fine to me. But I couldn't find any information regarding the confirm summary page. I know that this section will have a mid-summary in the flow. |
|
Sure, thats fine. As per the figma and JIRA, next route is the I’ve added the comment in the JIRA. Any other specific information you want me to add? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
EPP-160 - PRECURSOR DETAILS page
Why?
PRECURSOR DETAILS page is created to users can select the details for the selected precursor
How?
Testing?
Local and branch testing
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit