EPP-163, 164 Under 18 Redirection - Edit Journey #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekkumar-ho
changed the title
vivekkumar-ho
changed the title
vivekkumar-ho
requested review from
MikeMaratheftis,
PaolaDMadd-Pro and
william-gu-hof
william-gu-hof
approved these changes
Feb 18, 2025
| @@ -207,6 +212,10 @@ module.exports = { | |||
| fields: ['amend-countersignatory-document-type'], | |||
| next: '/confirm' | |||
| }, | |||
| '/birth-certificate': { | |||
| fields: [], | |||
There was a problem hiding this comment.
no fields on this step? Is this step used for these 2 tickets?
There was a problem hiding this comment.
@william-gu-hof This is just a placeholder route to validate the navigation. The page is not built yet.
No, this is only used in amend. new-renew /birth-certificate route already exists so I didn't add that.
| @@ -5,6 +5,9 @@ | |||
| "name-on-licence": { | |||
| "header": "What is your name on the licence?" | |||
| }, | |||
| "date-of-birth": { | |||
| "header": "What is your date of birth?" | |||
| }, | |||
There was a problem hiding this comment.
I noticed that there was a bug with the page header and now I realise why since the path name changed from amend-date-of-birth to date-of-birth can you remove the unused code please from line 17th?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
https://collaboration.homeoffice.gov.uk/jira/browse/EPP-163 - Amend - Edit Journey for DOB page
https://collaboration.homeoffice.gov.uk/jira/browse/EPP-164 - New & Renew - Edit Journey for DOB page
Why?
EPP-163 & EPP-164 are combined into a single PR because they are using the same behaviour and have same implementation logic. Grouping them together minimise redundant reviews, and duplicate code effort.
How?
New behaviour has been added to validate the date and redirect if required
Helper is created to verify the edit journey
Testing?
Local and branch testing
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit