Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPP-229 Routing Update #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vivekkumar-ho
Copy link
Contributor

@vivekkumar-ho vivekkumar-ho commented Feb 19, 2025

What?

EPP-229 - Routing logic for home address page

Why?

After the design change, if the moved date no longer meets the 'more than 5 year' condition then the user should progress to the previous-address page.

How?

Routing is updated to /previous-address

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

Copy link
Contributor

@PaolaDMadd-Pro PaolaDMadd-Pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants