[10주차/여니] 워크북 제출합니다 #60
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
가독성을 고려해 컨트롤러 구현체에도 파라미터 검증 어노테이션을 적용함.
kfdsy0103
approved these changes
Dec 21, 2025
Collaborator
kfdsy0103
left a comment
kfdsy0103
left a comment
There was a problem hiding this comment.
10주차 워크북까지 수행하시느라 수고 많으셨어요 여니!
리뷰 확인 후 머지 부탁드려요!
Comment on lines
+82
to
+96
| // 회원가입 | ||
| @PostMapping("/sign-up") | ||
| public ApiResponse<MemberResDTO.JoinDTO> signUp2( | ||
| @RequestBody @Valid MemberReqDTO.JoinDTO dto | ||
| ) { | ||
| return ApiResponse.onSuccess(MemberSuccessCode.FOUND, memberCommandService.signUp(dto)); | ||
| } | ||
|
|
||
| // 로그인 | ||
| @PostMapping("/login") | ||
| public ApiResponse<MemberResDTO.LoginDTO> login2( | ||
| @RequestBody @Valid MemberReqDTO.LoginDTO dto | ||
| ) { | ||
| return ApiResponse.onSuccess(MemberSuccessCode.FOUND, memberQueryService.login(dto)); | ||
| } |
Collaborator
There was a problem hiding this comment.
'로그인/회원가입'과 같이 권한 관련 코드들은 Member가 아닌, 따로 Auth 패키지를 파서 관리하기도 한답니다!
참고해주세요!
Comment on lines
+38
to
+51
| .authorizeHttpRequests(requests -> requests | ||
| .requestMatchers(allowUris).permitAll() | ||
| .requestMatchers("/swagger-ui/index.html").hasRole("ADMIN") | ||
| .anyRequest().authenticated() | ||
| ) | ||
| .addFilterBefore(jwtAuthFilter(), UsernamePasswordAuthenticationFilter.class) | ||
| .formLogin(AbstractHttpConfigurer::disable) | ||
| .csrf(AbstractHttpConfigurer::disable) | ||
| .logout(logout -> logout | ||
| .logoutUrl("/logout") | ||
| .logoutSuccessUrl("/login?logout") | ||
| .permitAll() | ||
| ) | ||
| .exceptionHandling(exception -> exception.authenticationEntryPoint(authenticationEntryPoint())) |
Collaborator
There was a problem hiding this comment.
JWT를 사용한다면 세션 비활성화를 명시적으로 적어주는 것도 좋아보이네요!
http
.sessionManagement(session ->
session.sessionCreationPolicy(SessionCreationPolicy.STATELESS));
Comment on lines
+21
to
+25
| jwt: | ||
| token: | ||
| secretKey: ${JWT_SECRET_KEY} | ||
| expiration: | ||
| access: ${JWT_EXPIRATION_ACCESS} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ 실습 체크리스트
✅ 컨벤션 체크리스트
📌 주안점