♻️ [Refactor] StudyRouter CRUD case 확장 + StudyRepository CRUD 실구현#919
Open
jwon0523 wants to merge 3 commits into
Open
♻️ [Refactor] StudyRouter CRUD case 확장 + StudyRepository CRUD 실구현#919jwon0523 wants to merge 3 commits into
jwon0523 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #886
✨ PR 유형
♻️ [Refactor] — 레거시
AppProduct/의 스터디 그룹 CRUD를 신규UMCApp/(Tuist) 모듈로 이식📷 스크린샷 or 영상(UI 변경 시)
🛠️ 작업내용
8차 계획의 스터디 그룹 Data 레이어 CRUD를 완성합니다. #814에서 스텁으로 남겨둔 CRUD를 실구현으로 전환했습니다.
StudyGroupCreateRequestDTO/StudyGroupUpdateRequestDTO/StudyGroupScheduleCreateRequestDTOperformVoidRequest헬퍼로 통합, 미구현 표식StudyRepositoryErrorenum 제거📋 추후 진행 상황
searchChallengersOffset등)📌 리뷰 포인트
핵심 의사결정 2가지를 중점적으로 봐주세요:
DecideAttendanceItemDTO(participantMemberId를 String 직렬화) 선례를 따라 문자열로 직렬화했습니다. 생성/멤버/멘토/일정 엔드포인트가 문자열 ID를 수용하는지 서버 스펙 확인 부탁드립니다./api/v1/study-groups— 레거시 및 기존 이식 case와 동일하게 v1 사용 (코드베이스에/api/v2/study-groups부재).StudyRepository.swift—performVoidRequest의 빈 본문(2xx) 성공 처리 (DELETE 등 본문 없는 응답 대비)StudyRouter.swift— CRUD case의 method/task 매핑 대칭성✅ Checklist
PR이 다음 요구 사항을 충족하는지 확인해주세요!!!