♻️ [Refactor] 멤버 조회 UseCase 2종 이식 (FetchMembersUseCase + FetchUserIdUseCase)#921
Open
jwon0523 wants to merge 2 commits into
Open
♻️ [Refactor] 멤버 조회 UseCase 2종 이식 (FetchMembersUseCase + FetchUserIdUseCase)#921jwon0523 wants to merge 2 commits into
jwon0523 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #892
✨ PR 유형
♻️ [Refactor] — 레거시
AppProduct/→UMCApp/(Tuist)ActivityDomain모듈 이식📷 스크린샷 or 영상(UI 변경 시)
🛠️ 작업내용
멤버 관리 도메인의 조회 UseCase 2종을
ActivityDomain모듈로 이식했습니다.MemberRepositoryProtocol(♻️ Refactor: 멤버 도메인 모델 + MemberRepositoryProtocol 이식 — v2 스펙 기준 #888) 단독 의존. 멤버 목록(전체/페이지) + 챌린저 상벌점 부여·삭제·이력 + 멤버 상세를 8-메서드 facade로 위임. 서버 식별자 전부String통일(레거시Int→String).CurrentUserIdProviding인터페이스에 의존.#if DEBUG가드) 작성.📋 추후 진행 상황
MemberListViewModel/OperatorMemberDetailSheetViewModel이식 (본 PR이 선행 기반).CurrentUserIdProvidingData 구현 시AppStorageKey.memberIdString()(String) 사용 권장.FetchMembersUseCase가 조회 + 상벌점 mutation을 함께 노출 → read/write 분리 또는MemberManagementUseCase개명 검토.📌 리뷰 포인트
FetchUserIdUseCase가MemberRepositoryProtocol에 의존한다고 전제했으나, 실제 레거시는ActivityRepositoryProtocol.fetchCurrentUserId()(로컬 세션 read)에 의존. 멤버관리 repository에 current-user-id를 얹는 건 책임 불일치라, 머지된 ♻️ Refactor: 멤버 도메인 모델 + MemberRepositoryProtocol 이식 — v2 스펙 기준 #888 protocol 미수정 + 전용CurrentUserIdProviding분리. → 적절성 리뷰 부탁.…/Domain/Sources/UseCases/— facade 위임 정확성 /StringID 통일.…/Domain/Sources/Interfaces/CurrentUserIdProviding.swift— seam 위치 +async throws계약.…/Domain/Tests/UseCases/— Mock 계약, 에러 전파 형제 대칭(파라미터화),#if DEBUG범위.✅ Checklist