♻️ [Refactor] NoticeEditor RichTextEditor 구조 리팩터링 및 AttachmentToolbar · Sheets 이관 (#929)#931
Open
LeeYeJi546 wants to merge 6 commits into
Open
♻️ [Refactor] NoticeEditor RichTextEditor 구조 리팩터링 및 AttachmentToolbar · Sheets 이관 (#929)#931LeeYeJi546 wants to merge 6 commits into
LeeYeJi546 wants to merge 6 commits into
Conversation
- 구 위치(Views/MarkdownSerializer.swift)에서 Serializer/ 디렉토리로 분리 - 파서/직렬화기 역할별 파일 분리: MarkdownBlockParser, MarkdownInlineParser, MarkdownBlockSerializer, MarkdownInlineSerializer, MarkdownAttributeBuilder, MarkdownAutoformat, MarkdownEscaping, MarkdownHTMLDetector, MarkdownRegex, MarkdownSerializerTypes
- RichTextViewRepresentable: SwiftUI UIViewRepresentable 래퍼 - RichTextCoordinator: 에디터 핵심 Coordinator (델리게이트/이벤트 관리) - 기능별 Coordinator 확장 분리: +Blockquote, +List, +MarkdownAutoformat, +Placeholder, +Scroll - BlockquoteTextView: 인용구 렌더링 커스텀 서브클래스 수정 - UITextView+MinimumHeight: 최소 높이 보장 익스텐션
- DefaultToolbarView: 기본 텍스트 편집 툴바 - TextSelectedToolbarView: 텍스트 선택 시 컨텍스트 툴바 - TableCellToolbarView: 표 셀 편집 전용 툴바
- 서식 적용 패널 UI 구현 (굵기/기울임/목록/인용구 등 포맷 옵션 제공)
- NoticePresentation 파일 헤더의 모듈명이 NoticeData 등으로 잘못 기재된 것 수정 - CoreUIComponents 파일 헤더 UMCFoundation 오기 정정
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
리팩터링 (♻️ Refactor) — NoticeEditor RichTextEditor 구조 개편 및 AttachmentToolbar · Sheets AppProduct → UMCApp 이관
📷 스크린샷 or 영상(UI 변경 시)
🛠️ 작업내용
Views/MarkdownSerializer.swift단일 파일을Serializer/디렉토리로 분리RichTextViewRepresentable: SwiftUI UIViewRepresentable 래퍼RichTextCoordinator: 에디터 핵심 Coordinator (델리게이트/이벤트 관리)BlockquoteTextView인용구 렌더링 수정,UITextView+MinimumHeight익스텐션 추가DefaultToolbarView,TextSelectedToolbarView,TableCellToolbarViewNoticeData→NoticePresentation등)📋 추후 진행 상황
📌 리뷰 포인트
NoticeEditor/RichTextEditor/Serializer/— Markdown 파싱·직렬화 로직 정확도 확인NoticeEditor/RichTextEditor/NoticeRichText/— UITextView Coordinator 이벤트 흐름 및 메모리 관리 확인NoticeEditor/RichTextEditor/Toolbar/·FormatPanel/— 툴바·서식 패널 UI 및 액션 연결 확인NoticeEditor/AttachmentToolbar/— 이관된 첨부 툴바 UI 및 PhotosPicker·투표 연동 확인NoticeEditor/Sheets/— TargetSheetView·VotingFormSheetView 시트 데이터 바인딩 확인✅ Checklist
PR이 다음 요구 사항을 충족하는지 확인해주세요!!!