Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though using the maximum theoretical limit (defined by
PG_MAX_QUERY_PARAMS
) works, it takes a significant performance toll. The change came after this comment, in which I suggested exploring the batch size increase.I noticed the slowness when trying to use this query:
With batch size of 1000, this takes ~13 seconds and with maximum theoretical batch size it never completes (I let it for about 20 mins) and needed
shm_size: 1g
on PostgreSQL container.