Add rental history filter options

[Gwonwoo-Nam]

Summary

• support filtering rental histories by store and payment status
• expand HistoryFilterRequest with storeId and paid
• update QueryDSL repository to apply new filters

Testing

• ./gradlew test --no-daemon (fails: Unable to tunnel through proxy)

---

https://chatgpt.com/codex/tasks/task_e_6841bd12d994832d9e0e6c8f9cf396c3

Summary by CodeRabbit

• New Features
  • Added new filtering options for rental history, allowing users to filter by store and payment status.

[coderabbitai]

Walkthrough

The changes extend the filtering capabilities for rental history queries by adding storeId and paid fields to the HistoryFilterRequest data class and updating the repository implementation to support filtering by these new criteria. New private methods handle the additional filters in query construction.

Changes

File(s)	Change Summary
src/main/kotlin/upbrella/be/rent/dto/request/HistoryFilterRequest.kt	Added nullable storeId and paid properties to the filter request data class.
src/main/kotlin/upbrella/be/rent/repository/RentRepositoryImpl.kt	Enhanced query methods to filter by storeId and paid using new private helper methods.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Controller
    participant RentRepositoryImpl
    participant Database

    Client->>Controller: Send HistoryFilterRequest (may include storeId, paid, refunded)
    Controller->>RentRepositoryImpl: Call findAll/findHistoryInfos/countAll with filter
    RentRepositoryImpl->>RentRepositoryImpl: Apply filterRefunded, filterPaid, filterStore
    RentRepositoryImpl->>Database: Query with combined filters
    Database-->>RentRepositoryImpl: Return filtered results
    RentRepositoryImpl-->>Controller: Return data
    Controller-->>Client: Respond with filtered history

Loading

Possibly related PRs

• refactor: rent dto migrate #481: Migrated Java DTOs to Kotlin, including removal of the Java HistoryFilterRequest. The current PR builds on this by enhancing the new Kotlin DTO and repository filtering.

Poem

In the meadow where queries grow,
Rabbits filter to and fro.
Now with store and paid in view,
History’s clearer, fresh as dew.
More precise, the data flows,
As every bunny surely knows!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 231f159 and f073006.

📒 Files selected for processing (2)

• src/main/kotlin/upbrella/be/rent/dto/request/HistoryFilterRequest.kt (1 hunks)
• src/main/kotlin/upbrella/be/rent/repository/RentRepositoryImpl.kt (4 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: test

🔇 Additional comments (8)

src/main/kotlin/upbrella/be/rent/dto/request/HistoryFilterRequest.kt (2)

3-7: LGTM! Clean data class extension.

The new fields storeId and paid follow the established pattern with appropriate nullable types and default values, maintaining consistency with the existing refunded field.

---

4-6: LGTM! Well-structured filter request.

The new filter fields follow the same pattern as the existing refunded field with appropriate nullable types and null defaults. This design allows for optional filtering while maintaining consistency.

src/main/kotlin/upbrella/be/rent/repository/RentRepositoryImpl.kt (6)

26-30: Excellent consistency across query methods.

All three query methods (findAll, findHistoryInfos, countAll) are consistently updated with the same filter combination, ensuring uniform filtering behavior across different operations.

Also applies to: 64-68, 78-82

---

112-122: Well-implemented filter method.

The filterPaid method correctly uses the paidAt timestamp to determine payment status and follows the established pattern from filterRefunded. The logic is sound: paid=true filters for records with paidAt not null, paid=false filters for null paidAt.

---

124-126: Clean and concise store filter implementation.

The method correctly filters by rentStoreMeta.id (rental store) using idiomatic Kotlin null-safe operators. This choice to filter by rental store rather than return store aligns with the typical use case of tracking where items were originally rented.

---

26-30: Excellent consistency in filter application.

All three query methods now consistently apply the same filters in the same order, which ensures uniform behavior across different query operations. The QueryDSL where clause usage is correct.

Also applies to: 64-68, 78-82

---

112-122: Clean implementation of payment status filtering.

The filterPaid method correctly handles the boolean logic:

• Returns null when no filter is needed (filter.paid == null)
• Uses paidAt.isNotNull for paid records and paidAt.isNull for unpaid records
• Proper null handling throughout

---

124-126: Efficient store filtering implementation.

The filterStore method uses Kotlin's safe call operator with let effectively:

• Returns null when no store filter is specified
• Creates an equality condition against rentStoreMeta.id when storeId is provided
• Concise and readable implementation

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.